From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH kvm-unit-tests v2 00/12] Improve the output of test runners Date: Fri, 18 Dec 2015 12:57:42 -0600 Message-ID: <20151218185742.GF3885@hawk.localdomain> References: <1450374823-7648-1-git-send-email-rkrcmar@redhat.com> <20151217200453.GK14168@hawk.localdomain> <20151218123830.GF21525@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46188 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932502AbbLRS5s (ORCPT ); Fri, 18 Dec 2015 13:57:48 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id B37188E6E3 for ; Fri, 18 Dec 2015 18:57:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20151218123830.GF21525@potion.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Dec 18, 2015 at 01:38:31PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: > 2015-12-17 14:04-0600, Andrew Jones: > > On Thu, Dec 17, 2015 at 06:53:31PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99= wrote: > >> v1: http://www.spinics.net/lists/kvm/msg125202.html > >>=20 > >> Drew brought up the existence of scripts/mkstandalone.sh, which > >> significantly expanded v2 (and my set of curses) ... > >> I didn't want to do the same twice, so first part of this series, > >> [1-4/12], reuses run() from run_tests.sh and does some non-conserv= ative > >> changes to scripts/mkstandalone.sh. scripts/mkstandalone.sh is la= cking > >> behind run_tests.sh, but should be good enough to fulfill its purp= ose. > >>=20 > >> The output of run_tests.sh has also changed a bit and now looks li= ke > >> this (you'll again need to imagine colours): > >>=20 > >> > PASS apic (14 tests) > >> > PASS ioapic (19 tests) > >> > PASS smptest (1 tests) > >> > PASS smptest3 (1 tests) > >> > PASS vmexit_cpuid > >> > PASS vmexit_vmcall > >=20 > > Why do some tests, which have only 1 test, say (1 tests), but other > > tests don't say anything? >=20 > Some tests don't use lib/report, hence don't print "^SUMMARY:", so we > don't really want to know what happens there. >=20 > > Some nice improvements with this series. I'm not sure I like depend= ing > > on bash in standalone tests, but then that could just be cause I wo= rked > > pretty hard at avoiding the dependency, and thus I'll have to cry a= t the > > loss of it... >=20 > Knowing the percentage of KVM+QEMU installations without bash would > help. I expect it to be very close to zero, which makes compassion h= ard > to find ... sorry. I'll look at the mkstandalone changes again. If taking a bash dependenc= y to maintain our sanity is necessary, then I won't fight it. >=20 > > Please review the series I'll send in about 2 minutes, so we can di= scuss > > how to integrate them. >=20 > Will do, thanks. (Please excuse the delay.) > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html