From: Marcelo Tosatti <mtosatti@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Radim Krcmar <rkrcmar@redhat.com>, kvm list <kvm@vger.kernel.org>
Subject: Re: What's kvmclock's custom sched_clock for?
Date: Thu, 7 Jan 2016 18:15:43 -0200 [thread overview]
Message-ID: <20160107201541.GB18469@amt.cnet> (raw)
In-Reply-To: <CALCETrXitaVmUuF22dayGBzFJ4hS6Th-Bmo7oebFG=ZSd=ADiQ@mail.gmail.com>
On Thu, Jan 07, 2016 at 09:27:30AM -0800, Andy Lutomirski wrote:
> On Thu, Jan 7, 2016 at 2:56 AM, Marcelo Tosatti <mtosatti@redhat.com> wrote:
> > On Wed, Jan 06, 2016 at 11:18:51PM -0800, Andy Lutomirski wrote:
> >> AFAICT KVM reliably passes a monotonic TSC through to guests,
> >
> > It does not.
>
> Under what circumstances does it go backwards? All hosts support tsc
> offsets, I think, and the host code knows how to prevent the clock
> from going backwards even on host suspend.
>
> Does migration make the TSC go backwards? If so, that's impolite and
> it would be nice to fix it.
TSC clocksource in the host is required for TSC masterclock scheme.
A change from TSC clocksource to a different clocksource, in the host,
invalidates TSC masterclock scheme.
If you change from TSC clocksource to HPET clocksource, for example,
TSC masterclock scheme stops functioning and its necessary to
stop exposing PVCLOCK_TSC_STABLE_CLOCK.
Please send a fix, your patch is causing breakage.
next prev parent reply other threads:[~2016-01-07 20:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 7:18 What's kvmclock's custom sched_clock for? Andy Lutomirski
2016-01-07 8:41 ` Andy Lutomirski
2016-01-07 10:59 ` Marcelo Tosatti
2016-01-07 15:18 ` Radim Krcmar
2016-01-07 17:27 ` Andy Lutomirski
2016-01-07 17:48 ` Radim Krcmar
2016-01-07 20:15 ` Marcelo Tosatti [this message]
2016-01-07 20:10 ` Marcelo Tosatti
2016-01-08 14:13 ` Radim Krcmar
2016-01-11 21:00 ` Marcelo Tosatti
2016-01-12 15:33 ` Radim Krcmar
2016-01-12 20:48 ` Marcelo Tosatti
2016-01-13 14:59 ` Radim Krcmar
2016-01-07 10:56 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107201541.GB18469@amt.cnet \
--to=mtosatti@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).