From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [PATCH] KVM: PPC: fix ONE_REG AltiVec support Date: Thu, 14 Jan 2016 14:38:07 +1100 Message-ID: <20160114033807.GA24745@fergus.ozlabs.ibm.com> References: <20160113171751.24877.58919.stgit@bahia.huguette.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Graf , mihai.caraman@freescale.com, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Paolo Bonzini To: Greg Kurz Return-path: Received: from ozlabs.org ([103.22.144.67]:51924 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755108AbcANDtz (ORCPT ); Wed, 13 Jan 2016 22:49:55 -0500 Content-Disposition: inline In-Reply-To: <20160113171751.24877.58919.stgit@bahia.huguette.org> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jan 13, 2016 at 06:28:17PM +0100, Greg Kurz wrote: > The get and set operations got exchanged by mistake when moving the > code from book3s.c to powerpc.c. > > Fixes: 3840edc8033ad5b86deee309c1c321ca54257452 > Signed-off-by: Greg Kurz > --- > > I posted the very same patch before the holidays but it did not gain > attention. It is very surprising that the error did not cause trouble > for such a long time... I discovered it by accident while implementing > gdbstubs for VSX registers in QEMU. But I guess it is also likely to > break migration of guests that do AltiVec. > > I am not sure if Alex is available to handle this patch... since the > error is obvious and the fix straightforward, can this patch be applied > by someone else ? Paulus ? Paolo ? I'll take it and add it to my upcoming pull request to Paolo. Paul.