Re: [kvm-unit-tests PATCH v2 00/10] share pci-testdev with the framework

[Andrew Jones <drjones@redhat.com>]

On Fri, Jan 15, 2016 at 10:57:33PM +0100, Radim Krčmář wrote:
> 2016-01-15 17:51+0100, Andrew Jones:
> > This series moves code around in order to liberate some
> > pci and pci-testdev code from x86-only territory. There
> > are no functional changes, but now x86 unit tests also get
> > to enjoy asm-generic/io.h and asm-generic/page.h defines.
> > 
> > A couple other non-function changes made are; the value
> > of PCIDEVADDR_INVALID is now more invalid, and we import
> > linux-uapi/pci_regs.h, which is necessary for additional
> > architectures to use lib/pci.
> > 
> > v2: cleaner moving of pci from lib/x86 to lib
> > 
> > 
> > Andrew Jones (10):
> >   asm-generic: add portio accessors to io.h
> >   x86: move io.h to asm
> 
> I'd like to see changes in first two patches.

How about we just drop #include "asm-generic/io.h" to avoid
x86 code needing the ugly #define stuff?

> 
> >   x86: use common portio accessors from io.h
> >   x86: pci.h: remove useless include
> >   x86: move x86/pci to the common lib
> >   x86: share pci-testdev hdr in common lib
> >   lib/pci: make PCIDEVADDR_INVALID truly invalid
> >   lib: add linux dir for kernel uapi headers
> >   Revert "arm/arm64: import include/uapi/linux/psci.h"
> >   lib/linux: import pci_regs.h
> 
> The rest,
> 
> Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>

Thanks!

drew

> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html