From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [kvm-unit-tests PATCH v2 00/10] share pci-testdev with the framework Date: Mon, 18 Jan 2016 15:01:01 +0100 Message-ID: <20160118140101.GF4075@hawk.localdomain> References: <1452876695-9240-1-git-send-email-drjones@redhat.com> <20160115215732.GB12949@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, pbonzini@redhat.com, mst@redhat.com, agordeev@redhat.com To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57758 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754972AbcAROBG (ORCPT ); Mon, 18 Jan 2016 09:01:06 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 6972CC077547 for ; Mon, 18 Jan 2016 14:01:06 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160115215732.GB12949@potion.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jan 15, 2016 at 10:57:33PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: > 2016-01-15 17:51+0100, Andrew Jones: > > This series moves code around in order to liberate some > > pci and pci-testdev code from x86-only territory. There > > are no functional changes, but now x86 unit tests also get > > to enjoy asm-generic/io.h and asm-generic/page.h defines. > >=20 > > A couple other non-function changes made are; the value > > of PCIDEVADDR_INVALID is now more invalid, and we import > > linux-uapi/pci_regs.h, which is necessary for additional > > architectures to use lib/pci. > >=20 > > v2: cleaner moving of pci from lib/x86 to lib > >=20 > >=20 > > Andrew Jones (10): > > asm-generic: add portio accessors to io.h > > x86: move io.h to asm >=20 > I'd like to see changes in first two patches. How about we just drop #include "asm-generic/io.h" to avoid x86 code needing the ugly #define stuff? >=20 > > x86: use common portio accessors from io.h > > x86: pci.h: remove useless include > > x86: move x86/pci to the common lib > > x86: share pci-testdev hdr in common lib > > lib/pci: make PCIDEVADDR_INVALID truly invalid > > lib: add linux dir for kernel uapi headers > > Revert "arm/arm64: import include/uapi/linux/psci.h" > > lib/linux: import pci_regs.h >=20 > The rest, >=20 > Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99 Thanks! drew > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html