From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH kvm-unit-tests 03/12] scripts/mkstandalone: refactor temp file creation Date: Tue, 19 Jan 2016 15:53:54 +0100 Message-ID: <20160119145353.GA611@potion.brq.redhat.com> References: <1453209851-27760-1-git-send-email-rkrcmar@redhat.com> <1453209851-27760-4-git-send-email-rkrcmar@redhat.com> <569E4C43.1020003@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Andrew Jones To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39304 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754297AbcASOx5 (ORCPT ); Tue, 19 Jan 2016 09:53:57 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 70E9A8F868 for ; Tue, 19 Jan 2016 14:53:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <569E4C43.1020003@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2016-01-19 15:46+0100, Paolo Bonzini: > On 19/01/2016 14:24, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: >> + >> + echo "cleanup=3D\"\$$var \$cleanup\"" >> + echo "$var=3D\`mktemp\`" >=20 > $var is not yet defined when you update cleanup. Ah, I missed that bug. I'll add `unset var`, so we don't accidentaly delete something.