Re: [PATCH kvm-unit-tests 00/12] scripts/mkstandalone: rewrite

["Radim Krčmář" <rkrcmar@redhat.com>]

2016-01-19 15:49+0100, Paolo Bonzini:
> On 19/01/2016 14:23, Radim Krčmář wrote:
>> Drew and I have shelved series' where mkstandalone was duplicating the
>> effort.  This patchset should make future changes much simpler by
>> reusing code from other files in standalone tests.
> 
> Nice!  Tacked on the following at the end, and pushed.

Thanks!  (Seems like I won't be doing a v2, then :])

> commit c8104a66356d03d5dbb264422023297e8ec34652
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date:   Tue Jan 19 15:47:48 2016 +0100
> 
>     scripts/mkstandalone: document what it writes to
> 
>     Makes it a bit less puzzling. :)

Definitely.

>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh
> index 1e0da8e..5891005 100755
> --- a/scripts/mkstandalone.sh
> +++ b/scripts/mkstandalone.sh
> @@ -71,6 +71,7 @@ function mkstandalone()
>  	generate_test "$@" > $standalone
> 
>  	chmod +x $standalone
> +	echo Written $standalone.
> 
>  	return 0
>  }
> 
> 
> Paolo