From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH kvm-unit-tests 00/12] scripts/mkstandalone: rewrite Date: Tue, 19 Jan 2016 15:56:51 +0100 Message-ID: <20160119145651.GD14830@potion.brq.redhat.com> References: <1453209851-27760-1-git-send-email-rkrcmar@redhat.com> <569E4CE6.4060702@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Andrew Jones To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60600 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755652AbcASO4y (ORCPT ); Tue, 19 Jan 2016 09:56:54 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id BE83F471 for ; Tue, 19 Jan 2016 14:56:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: <569E4CE6.4060702@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2016-01-19 15:49+0100, Paolo Bonzini: > On 19/01/2016 14:23, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: >> Drew and I have shelved series' where mkstandalone was duplicating t= he >> effort. This patchset should make future changes much simpler by >> reusing code from other files in standalone tests. >=20 > Nice! Tacked on the following at the end, and pushed. Thanks! (Seems like I won't be doing a v2, then :]) > commit c8104a66356d03d5dbb264422023297e8ec34652 > Author: Paolo Bonzini > Date: Tue Jan 19 15:47:48 2016 +0100 >=20 > scripts/mkstandalone: document what it writes to >=20 > Makes it a bit less puzzling. :) Definitely. > Signed-off-by: Paolo Bonzini >=20 > diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh > index 1e0da8e..5891005 100755 > --- a/scripts/mkstandalone.sh > +++ b/scripts/mkstandalone.sh > @@ -71,6 +71,7 @@ function mkstandalone() > generate_test "$@" > $standalone >=20 > chmod +x $standalone > + echo Written $standalone. >=20 > return 0 > } >=20 >=20 > Paolo