From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH kvm-unit-tests 00/12] scripts/mkstandalone: rewrite Date: Tue, 19 Jan 2016 16:20:12 +0100 Message-ID: <20160119152012.GC13745@hawk.localdomain> References: <1453209851-27760-1-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45522 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754491AbcASPUR (ORCPT ); Tue, 19 Jan 2016 10:20:17 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 80B63C09FAB9 for ; Tue, 19 Jan 2016 15:20:17 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1453209851-27760-1-git-send-email-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jan 19, 2016 at 02:23:59PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: > Drew and I have shelved series' where mkstandalone was duplicating th= e > effort. This patchset should make future changes much simpler by > reusing code from other files in standalone tests. Thanks Radim! This definitely makes mkstandalone much, much more maintainable. Long-live Bash :-) I'll rework my return code and timeout support patches on top of this, and post them soon. Paolo, I noticed you wrote 'applied', but I guess you haven't yet pushed. Thanks, drew >=20 >=20 > Radim Kr=C4=8Dm=C3=A1=C5=99 (12): > scripts/mkstandalone: simplify redirection > scripts/mkstandalone: fix ARCH > scripts/mkstandalone: refactor temp file creation > scripts/mkstandalone: use bash in standalone test > scripts/mkstandalone: reuse $TEST_DIR/run > run_tests: move reusable code to scripts/runtime > scripts/runtime: change callsite of $TEST_DIR/run > scripts/mkstandalone: refactor check for test kernel > scripts/mkstandalone: use scripts/runtime > scripts/mkstandalone: simplifiy redirection, again > scripts/mkstandalone: sanitize one_kernel handling > scripts/mkstandalone: return the exit value of a test >=20 > run_tests.sh | 101 +---------------------------- > scripts/mkstandalone.sh | 164 +++++++++++++++++++-------------------= ---------- > scripts/runtime.bash | 103 ++++++++++++++++++++++++++++++ > 3 files changed, 169 insertions(+), 199 deletions(-) > create mode 100644 scripts/runtime.bash >=20 > --=20 > 2.7.0 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html