From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [kvm-unit-tests PATCH 2/6] mkstandalone: fix generation for arm Date: Tue, 26 Jan 2016 13:21:07 +0100 Message-ID: <20160126122107.GB10697@hawk.localdomain> References: <1453474709-10679-1-git-send-email-drjones@redhat.com> <1453474709-10679-3-git-send-email-drjones@redhat.com> <56A751FD.6040106@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, rkrcmar@redhat.com To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38825 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752924AbcAZMVL (ORCPT ); Tue, 26 Jan 2016 07:21:11 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 12C458EA48 for ; Tue, 26 Jan 2016 12:21:11 +0000 (UTC) Content-Disposition: inline In-Reply-To: <56A751FD.6040106@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jan 26, 2016 at 12:01:17PM +0100, Paolo Bonzini wrote: > > > On 22/01/2016 15:58, Andrew Jones wrote: > > The mkstandalone rewrite now packages the architecture run scripts. > > This brings many benefits, but at the cost of no longer being able > > to source additional files from the run script, at least not while > > in standalone mode. We can live with that, but arm/run was sourcing > > config.mak, so we need to stop that in standalone mode, as well as > > to provide the standalone arm/run script what it needs. > > > > Signed-off-by: Andrew Jones > > --- > > arm/run | 10 ++++++---- > > scripts/mkstandalone.sh | 11 ++++++++++- > > 2 files changed, 16 insertions(+), 5 deletions(-) > > > > diff --git a/arm/run b/arm/run > > index 4a648697d7fb5..0158ca5649a9f 100755 > > --- a/arm/run > > +++ b/arm/run > > @@ -1,10 +1,12 @@ > > #!/bin/bash > > > > -if [ ! -f config.mak ]; then > > - echo run ./configure first. See ./configure -h > > - exit 2 > > +if [ -z "$STANDALONE" ]; then > > What do you think about checking: > > if [ "${ARCH:+set}" != set ]; then > > instead? That's a nice trick, but I sort of prefer the explicit STANDALONE variable, and I see you already merged this version. Thanks, drew