From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [kvm-unit-tests PATCH 0/6] reduce exit status ambiguity and more Date: Wed, 27 Jan 2016 14:50:17 +0100 Message-ID: <20160127135016.GC20131@potion.brq.redhat.com> References: <1453833731-23215-1-git-send-email-drjones@redhat.com> <20160126215533.GH21252@potion.brq.redhat.com> <20160127103342.GA3910@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, pbonzini@redhat.com To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46349 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932176AbcA0NuU (ORCPT ); Wed, 27 Jan 2016 08:50:20 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 5F838C07752D for ; Wed, 27 Jan 2016 13:50:20 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160127103342.GA3910@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: 2016-01-27 11:33+0100, Andrew Jones: > On Tue, Jan 26, 2016 at 10:55:34PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99= wrote: >> 2016-01-26 19:42+0100, Andrew Jones: >>> The first three patches makes changes to reduce the exit status amb= iguity, >>> for which kvm-unit-tests is famous. The next couple are a cleanup a= nd a >>> minor feature enhancement. The last is a feature enhancement bringi= ng >>> timeouts to unittest runs. >>=20 >> I can accept that we don't care about bugs in [3/6], so if you insis= t, >=20 > I never insist. I'll fix it up with your suggestions. I also thought > of something else to fix. The standalone arch-run script is now the > concatenation of scripts/arch-run.bash and TEST_DIR/run, the former b= eing > first. scripts/arch-run.bash doesn't have a '#!/bin/bash' at the top. > I'll modify mkstandalone to make sure RUNTIME_arch_run always has bas= h > specified. True. The sad part is that it worked in tests, because sh =3D bash on many systems ... >> Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99 >=20 > I'll add your r-b's to all patches for v2. If you don't like somethin= g I > do for the changes then just complain and revoke it :-) Thanks.