From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH v2 15/21] arm64: KVM: VHE: Use unified sysreg accessors for timer Date: Mon, 1 Feb 2016 15:23:19 +0100 Message-ID: <20160201142319.GU1478@cbox> References: <1453737235-16522-1-git-send-email-marc.zyngier@arm.com> <1453737235-16522-16-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org To: Marc Zyngier Return-path: Content-Disposition: inline In-Reply-To: <1453737235-16522-16-git-send-email-marc.zyngier@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On Mon, Jan 25, 2016 at 03:53:49PM +0000, Marc Zyngier wrote: > Switch the timer code to the unified sysreg accessors. > > Signed-off-by: Marc Zyngier Reviewed-by: Christoffer Dall > --- > arch/arm64/kvm/hyp/timer-sr.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/timer-sr.c b/arch/arm64/kvm/hyp/timer-sr.c > index 1051e5d..f276d9e 100644 > --- a/arch/arm64/kvm/hyp/timer-sr.c > +++ b/arch/arm64/kvm/hyp/timer-sr.c > @@ -31,12 +31,12 @@ void __hyp_text __timer_save_state(struct kvm_vcpu *vcpu) > u64 val; > > if (kvm->arch.timer.enabled) { > - timer->cntv_ctl = read_sysreg(cntv_ctl_el0); > - timer->cntv_cval = read_sysreg(cntv_cval_el0); > + timer->cntv_ctl = read_sysreg_el0(cntv_ctl); > + timer->cntv_cval = read_sysreg_el0(cntv_cval); > } > > /* Disable the virtual timer */ > - write_sysreg(0, cntv_ctl_el0); > + write_sysreg_el0(0, cntv_ctl); > > /* Allow physical timer/counter access for the host */ > val = read_sysreg(cnthctl_el2); > @@ -64,8 +64,8 @@ void __hyp_text __timer_restore_state(struct kvm_vcpu *vcpu) > > if (kvm->arch.timer.enabled) { > write_sysreg(kvm->arch.timer.cntvoff, cntvoff_el2); > - write_sysreg(timer->cntv_cval, cntv_cval_el0); > + write_sysreg_el0(timer->cntv_cval, cntv_cval); > isb(); > - write_sysreg(timer->cntv_ctl, cntv_ctl_el0); > + write_sysreg_el0(timer->cntv_ctl, cntv_ctl); > } > } > -- > 2.1.4 >