Re: [kvm-unit-tests PATCH v3 01/17] arm/arm64: trivial: another assert fix

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

On Sat, Feb 13, 2016 at 05:28:14PM +0100, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> 
> ---
> Unrelated to the powerpc initial drop, but found it while working
> on that, so just posting it now. Anyway, it's a trivial fix.
> ---
>  lib/arm/io.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/arm/io.c b/lib/arm/io.c
> index a08d394e4aa1c..a111530f4802d 100644
> --- a/lib/arm/io.c
> +++ b/lib/arm/io.c
> @@ -50,7 +50,8 @@ static void uart0_init(void)
>  		}
>  
>  	} else {
> -		assert(dt_pbus_translate_node(ret, 0, &base) == 0);
> +		ret = dt_pbus_translate_node(ret, 0, &base);
> +		assert(ret == 0);
>  	}
>  
>  	uart0_base = ioremap(base.addr, base.size);

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]