From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neo Jia Subject: Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU. Date: Wed, 17 Feb 2016 02:34:09 -0800 Message-ID: <20160217103409.GB11166@nvidia.com> References: <20160217041743.GA7903@nvidia.com> <20160217053742.GA8839@nvidia.com> <20160217072610.GA9416@nvidia.com> <20160217075448.GC9416@nvidia.com> <20160217093430.GA11166@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: "Ruan, Shuai" , "Song, Jike" , "kvm@vger.kernel.org" , Kirti Wankhede , qemu-devel , Alex Williamson , Gerd Hoffmann , Paolo Bonzini , "Lv, Zhiyuan" , "Paul Durrant (Paul.Durrant@citrix.com)" , "Malcolm Crossley (malcolm.crossley@citrix.com)" To: "Tian, Kevin" Return-path: Received: from hqemgate16.nvidia.com ([216.228.121.65]:18370 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933850AbcBQKeM (ORCPT ); Wed, 17 Feb 2016 05:34:12 -0500 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Feb 17, 2016 at 09:52:04AM +0000, Tian, Kevin wrote: > > From: Neo Jia [mailto:cjia@nvidia.com] > > Sent: Wednesday, February 17, 2016 5:35 PM > > > > On Wed, Feb 17, 2016 at 08:57:08AM +0000, Tian, Kevin wrote: > > > > From: Neo Jia [mailto:cjia@nvidia.com] > > > > Sent: Wednesday, February 17, 2016 3:55 PM > > > > > If we can make it free, why not? > > I can buy-in this argument. Great! > > Qemu is not a kernel component. And UUID is OPTIONAL for Qemu. > > KVM is the kernel component. It doesn't use UUID at all. the relation between > UUID and VM is fully maintained in user space. Hold on ... we are talking about the vgpu.ko not KVM right? UUID is just a generic way to represent an object, here we use a uuid to represent a virtual gpu device. > > > > > Please also note that using UUID to represent a virtual gpu device directory > > doesn't mean UUID is part of a GPU resource. > > but it adds a hard dependency on another resource - UUID. > > > > > > > > > So let's keep UUID as an optional parameter. When UUID is provided, it > > > will be included in the vGPU name then your requirement can be met. > > > > > > > Like I have said before, we are seeking a generic interface to allow upper layer > > software stack to manage vgpu device for different vendors, so we should not really > > consider "an optional path for vgpu device discovery" at all. > > > > This is why I think we should use this UUID as a generic management interface, > > and we shouldn't have anything optional. > > > > I don't buy-in this argument. I always think kernel design should provide > enough flexibility, instead of assuming user space behavior. > I think you are using the wrong terms here. Flexibility doesn't apply here. What we are trying to achieve here is to have a generic interface for upper layer software to manage vgpu device. > Let me also add some Citrix friends. See how they feel about the necessity of > having UUID in vgpu name. Sorry? Thanks, Neo > > Thanks > Kevin