From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [kvm-unit-tests PATCH v5 16/18] mkstandalone: add support for
 powerpc
Date: Fri, 19 Feb 2016 14:53:46 +1100
Message-ID: <20160219035346.GW15224@voom.fritz.box>
References: <1455734459-31902-1-git-send-email-drjones@redhat.com>
 <1455734459-31902-17-git-send-email-drjones@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="hc4757KF+wLS/WHK"
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, thuth@redhat.com,
	dgibson@redhat.com, agraf@suse.de, lvivier@redhat.com,
	pbonzini@redhat.com, rkrcmar@redhat.com
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([103.22.144.67]:38974 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757180AbcBSD5L (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 18 Feb 2016 22:57:11 -0500
Content-Disposition: inline
In-Reply-To: <1455734459-31902-17-git-send-email-drjones@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


--hc4757KF+wLS/WHK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 17, 2016 at 07:40:57PM +0100, Andrew Jones wrote:
> PowerPC needs firmware.
>=20
> Signed-off-by: Andrew Jones <drjones@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  configure               | 2 ++
>  powerpc/run             | 2 +-
>  scripts/mkstandalone.sh | 5 +++++
>  3 files changed, 8 insertions(+), 1 deletion(-)
>=20
> diff --git a/configure b/configure
> index b2ad199da7873..7d5702e28d627 100755
> --- a/configure
> +++ b/configure
> @@ -83,6 +83,7 @@ elif [ "$arch" =3D "arm" ] || [ "$arch" =3D "arm64" ]; =
then
>      testdir=3Darm
>  elif [ "$arch" =3D "ppc64" ]; then
>      testdir=3Dpowerpc
> +    firmware=3D"$testdir/boot_rom.bin"
>  else
>      testdir=3D$arch
>  fi
> @@ -137,4 +138,5 @@ OBJDUMP=3D$cross_prefix$objdump
>  AR=3D$cross_prefix$ar
>  API=3D$api
>  TEST_DIR=3D$testdir
> +FIRMWARE=3D$firmware
>  EOF
> diff --git a/powerpc/run b/powerpc/run
> index 47aecb7600832..c5108100fc5e0 100755
> --- a/powerpc/run
> +++ b/powerpc/run
> @@ -42,7 +42,7 @@ fi
> =20
>  M=3D'-machine pseries'
>  M+=3D",accel=3D$ACCEL"
> -command=3D"$qemu $M -bios powerpc/boot_rom.bin"
> +command=3D"$qemu $M -bios $FIRMWARE"
>  command+=3D" -display none -serial stdio -kernel"
>  echo $command "$@"
> =20
> diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh
> index b0f1e7c098afb..c7e78f83fb086 100755
> --- a/scripts/mkstandalone.sh
> +++ b/scripts/mkstandalone.sh
> @@ -53,6 +53,11 @@ generate_test ()
> =20
>  	echo "trap 'rm -f \$cleanup' EXIT"
> =20
> +	if [ "$FIRMWARE" ]; then
> +		temp_file FIRMWARE "$FIRMWARE"
> +		echo 'export FIRMWARE'
> +	fi
> +
>  	temp_file bin "$kernel"
>  	args[3]=3D'$bin'
> =20

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--hc4757KF+wLS/WHK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWxpHKAAoJEGw4ysog2bOSiIAP/RL83a/14HeDrfFjpzeeoxeS
eVNK8qf3a+ZTH1cGIodIpR3pzAGC1yy/acuvy1/6AtZrOF3SD+YZWRfrN9n2M0h1
HoF7l6WJK0iotGNkwzUeOAAbPPCV200gsU1pmCRJE/jTIOMU0yFIBJAEerQzd72p
TkME4QX6DVor/VfriKrLTFbqtSpKrLN6fFEQOEyoKxk/2/79Efouy+kI0s4NF3Vv
H0jac2Wm8tRIRCQMxm4EJ1+jSzndlAFtyn0QgoWUv6a/yV0qoY9NlYqDESMpSJUV
eL2UYCAc9Zaw467LeUK9qYHYtrbV8WAffDdHDr/zxYnb7V81trIURGmvtOUJRFk1
+y7XBvKnoXPiS+vII+i9lVBdRHDxwTFdIcMJT/5ptdtDIz8m/zioOvSgiS2Fd+Ny
wV8RRS49LX3z29xwUIHYakBtB3M2MdtHbtwy11agqF85IByist251MQ8AieBnm7C
ki3W/Urf9QM7cabwojDM1bNtT1Fam6hOcNKecJZbDG3fVoLaEEizKaNYrt1LImfa
y7MzhPLgC40eKBjNmUsB8aY42CffIopJGeY4rtE6LZSNSvVNGMddrCh+LhQYsgLh
a5AbZkmyJYTzXLbZjK5LpaBahWao7IUMqnGN5Llf5gNetbmaEL/AGevKqfWlLx5R
7ZLe7UY7laOm5EZZcLTa
=Obeq
-----END PGP SIGNATURE-----

--hc4757KF+wLS/WHK--