From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [kvm-unit-tests PATCH v6 17/18] powerpc/ppc64: add RTAS support Date: Mon, 22 Feb 2016 14:26:28 +1100 Message-ID: <20160222032628.GE2808@voom.fritz.box> References: <1455897503-11835-1-git-send-email-drjones@redhat.com> <1455897503-11835-18-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9l24NVCWtSuIVIod" Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, thuth@redhat.com, dgibson@redhat.com, agraf@suse.de, lvivier@redhat.com, pbonzini@redhat.com, rkrcmar@redhat.com To: Andrew Jones Return-path: Received: from ozlabs.org ([103.22.144.67]:49221 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753163AbcBVE6s (ORCPT ); Sun, 21 Feb 2016 23:58:48 -0500 Content-Disposition: inline In-Reply-To: <1455897503-11835-18-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: --9l24NVCWtSuIVIod Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 19, 2016 at 04:58:22PM +0100, Andrew Jones wrote: > Add enough RTAS support to start adding RTAS commands. Just add > power-off for now. >=20 > Signed-off-by: Andrew Jones > Reviewed-by: Thomas Huth > Tested-by: Laurent Vivier > Reviewed-by: David Gibson > --- > lib/powerpc/asm/rtas.h | 26 +++++++++ > lib/powerpc/io.c | 2 + > lib/powerpc/rtas.c | 139 ++++++++++++++++++++++++++++++++++++++++++= ++++++ > lib/ppc64/asm/rtas.h | 1 + > powerpc/Makefile.common | 1 + > 5 files changed, 169 insertions(+) > create mode 100644 lib/powerpc/asm/rtas.h > create mode 100644 lib/powerpc/rtas.c > create mode 100644 lib/ppc64/asm/rtas.h >=20 > diff --git a/lib/powerpc/asm/rtas.h b/lib/powerpc/asm/rtas.h > new file mode 100644 > index 0000000000000..522225bcb6de3 > --- /dev/null > +++ b/lib/powerpc/asm/rtas.h > @@ -0,0 +1,26 @@ > +#ifndef _ASMPOWERPC_RTAS_H_ > +#define _ASMPOWERPC_RTAS_H_ > +/* > + * Copyright (C) 2016, Red Hat Inc, Andrew Jones > + * > + * This work is licensed under the terms of the GNU LGPL, version 2. > + */ > +#include > + > +#define RTAS_UNKNOWN_SERVICE (-1) > + > +struct rtas_args { > + u32 token; > + u32 nargs; > + u32 nret; > + u32 args[16]; > + u32 *rets; > +}; > + > +extern void rtas_init(void); > +extern int rtas_token(const char *service); > +extern int rtas_call(int token, int nargs, int nret, int *outputs, ...); > + > +extern void rtas_power_off(void); > + > +#endif /* _ASMPOWERPC_RTAS_H_ */ > diff --git a/lib/powerpc/io.c b/lib/powerpc/io.c > index ef90946fb1131..c4c61ea8ac1cf 100644 > --- a/lib/powerpc/io.c > +++ b/lib/powerpc/io.c > @@ -7,6 +7,7 @@ > */ > #include > #include > +#include > =20 > extern void halt(int code); > extern void putchar(int c); > @@ -15,6 +16,7 @@ static struct spinlock print_lock; > =20 > void io_init(void) > { > + rtas_init(); > } > =20 > void puts(const char *s) > diff --git a/lib/powerpc/rtas.c b/lib/powerpc/rtas.c > new file mode 100644 > index 0000000000000..464d066d3c220 > --- /dev/null > +++ b/lib/powerpc/rtas.c > @@ -0,0 +1,139 @@ > +/* > + * powerpc RTAS > + * > + * Copyright (C) 2016, Red Hat Inc, Andrew Jones > + * > + * This work is licensed under the terms of the GNU LGPL, version 2. > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define RTAS_BLOB_WORDS 8 > + > +#if defined(__powerpc64__) > +struct func_ptr { > + unsigned long ptr; > + unsigned long toc; > +}; > +static struct func_ptr rtas_entry_funcptr; > +#endif > +static u32 rtas_blob[RTAS_BLOB_WORDS]; > +typedef void (*rtas_entry_t)(unsigned long); > +static rtas_entry_t enter_rtas; > +static struct rtas_args rtas_args; > +static struct spinlock rtas_lock; > + > +static int rtas_node(void) > +{ > + int node =3D fdt_path_offset(dt_fdt(), "/rtas"); > + > + if (node < 0) { > + printf("%s: /rtas: %s\n", __func__, fdt_strerror(node)); > + abort(); > + } > + > + return node; > +} > + > +void rtas_init(void) > +{ > + bool broken_sc1 =3D hcall_have_broken_sc1(); > + int node =3D rtas_node(), len, words, i; > + const struct fdt_property *prop; > + u32 *data, *insns; > + > + if (!dt_available()) { > + printf("%s: No device tree!\n", __func__); > + abort(); > + } > + > + prop =3D fdt_get_property(dt_fdt(), node, > + "linux,rtas-entry", &len); > + if (!prop) { > + printf("%s: /rtas/linux,rtas-entry: %s\n", > + __func__, fdt_strerror(len)); > + abort(); > + } > + > + data =3D (u32 *)prop->data; > + insns =3D (u32 *)(unsigned long)fdt32_to_cpu(*data); > + > + prop =3D fdt_get_property(dt_fdt(), node, "rtas-size", &len); > + if (!prop) { > + printf("%s: /rtas/rtas-size: %s\n", > + __func__, fdt_strerror(len)); > + abort(); > + } > + data =3D (u32 *)prop->data; > + words =3D (int)fdt32_to_cpu(*data)/4; > + assert(words <=3D RTAS_BLOB_WORDS); > + > + for (i =3D 0; i < words; ++i) { > + rtas_blob[i] =3D be32_to_cpu(insns[i]); > + if (broken_sc1 && rtas_blob[i] =3D=3D SC1) > + rtas_blob[i] =3D SC1_REPLACEMENT; > + } Hmm.. in general it's not guaranteed that you can copy around the RTAS blob and have it still work. But.. you're working essentially at the same level as SLOF here, rather than a "normal" OS and I think SLOF must make the same assumption. So I guess it's ok. > +#if defined(__powerpc64__) Technically this ifdef should be based on the ABI version, rather than __powerpc64__, but I'm not sure if there are standard #defines for that. > + rtas_entry_funcptr.ptr =3D (unsigned long)rtas_blob; > + enter_rtas =3D (rtas_entry_t)&rtas_entry_funcptr; > +#else > + enter_rtas =3D (rtas_entry_t)rtas_blob; > +#endif I think you may want to have an actual coded enter_rtas function, rather than just constructing a function pointer around the raw blob. For one thing it should reduce the ugly ABI version #ifdefs. More importantly though, you can use it to set up the correct MSR state for entry into RTAS (IR, DR, EE off, big-endian, ..). At the moment all your code runs in a suitable MSR state to call directly into RTAS, but that will probably change fairly soon. > +} > + > +int rtas_token(const char *service) > +{ > + const struct fdt_property *prop; > + u32 *token; > + > + prop =3D fdt_get_property(dt_fdt(), rtas_node(), service, NULL); > + if (prop) { > + token =3D (u32 *)prop->data; > + return fdt32_to_cpu(*token); > + } > + return RTAS_UNKNOWN_SERVICE; > +} > + > +int rtas_call(int token, int nargs, int nret, int *outputs, ...) > +{ > + va_list list; > + int ret, i; > + > + spin_lock(&rtas_lock); > + > + rtas_args.token =3D cpu_to_be32(token); > + rtas_args.nargs =3D cpu_to_be32(nargs); > + rtas_args.nret =3D cpu_to_be32(nret); > + rtas_args.rets =3D &rtas_args.args[nargs]; > + > + va_start(list, outputs); > + for (i =3D 0; i < nargs; ++i) > + rtas_args.args[i] =3D cpu_to_be32(va_arg(list, u32)); > + va_end(list); > + > + for (i =3D 0; i < nret; ++i) > + rtas_args.rets[i] =3D 0; > + > + enter_rtas(__pa(&rtas_args)); > + > + if (nret > 1 && outputs !=3D NULL) > + for (i =3D 0; i < nret - 1; ++i) > + outputs[i] =3D be32_to_cpu(rtas_args.rets[i + 1]); > + > + ret =3D nret > 0 ? be32_to_cpu(rtas_args.rets[0]) : 0; > + > + spin_unlock(&rtas_lock); > + return ret; > +} > + > +void rtas_power_off(void) > +{ > + int ret =3D rtas_call(rtas_token("power-off"), 2, 1, NULL, -1, -1); > + printf("RTAS power-off returned %d\n", ret); abort here? > +} > diff --git a/lib/ppc64/asm/rtas.h b/lib/ppc64/asm/rtas.h > new file mode 100644 > index 0000000000000..fe77f635cd860 > --- /dev/null > +++ b/lib/ppc64/asm/rtas.h > @@ -0,0 +1 @@ > +#include "../../powerpc/asm/rtas.h" > diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common > index 07ba135f77110..cad728ecbe269 100644 > --- a/powerpc/Makefile.common > +++ b/powerpc/Makefile.common > @@ -28,6 +28,7 @@ cflatobjs +=3D lib/devicetree.o > cflatobjs +=3D lib/powerpc/io.o > cflatobjs +=3D lib/powerpc/hcall.o > cflatobjs +=3D lib/powerpc/setup.o > +cflatobjs +=3D lib/powerpc/rtas.o > =20 > libgcc :=3D $(shell $(CC) $(machine) --print-libgcc-file-name) > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --9l24NVCWtSuIVIod Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWyn/kAAoJEGw4ysog2bOSlyUP/3Br7azgvccF6QfpD7E3hqWC XCtcqYMvOFSjtRFO260wrArtc0dPMccn/22CQs+Zl9FQfyLiqekIyCyvBtHoVs7K cEFfNJ8m8p01pxK/sZeL/iJEP24IQfjiqDVEwr2kHRueRUwrD0QaGK3pYtlkn4Kw QNrwtcdeZxCjWL6RecGMiYnsTAtaYN3r10vD/ddX44RQrW4Op/PnYXpPdirItBIl +vY0NvJRz6bv/WOSJrNeNb4IZFlXOKUt0ft2ZcNO4HzDFo6L1R8yGXn6+IzUe5CP oYlltWO5Dg/GTgkWLNxq9oSzMsKF+50qQpJesvguWzVjxDfvNdfq7d8ts7rYwPk/ JdytMpSPm6AgxFOT9hOIwpHByhiVgcqh4Cs9JtsGy2Ow30io49GADuN+Nrsc6DDJ MGVID5yVULDGlc0+fVEeC2jrs7gF9mIZg+4MWfZ4LgNbG1oHe7w3kI0GRO04o30b Myv90UXNC6rA7hRF9O1DVcXkJJhuH54zdLqZOuXDbz07GUzXQWqwQ4sucSjSNsT7 U/K9aUU36r974puavf+aFAjICGXreZMxQ+zWrkegCFWGH6ynwxnLKAfpHQnOjeUN 26TjnouaOouMkvyIrpDtWgpMpOH2ZK6g0z7Yh2W2C6V47AhNJuzCnGMl8EdaHoNC RvwEv4XBKAlVd4X6yZ0T =pmCe -----END PGP SIGNATURE----- --9l24NVCWtSuIVIod--