From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [kvm-unit-tests PATCH v6 00/18] ppc64: initial drop Date: Sat, 27 Feb 2016 00:41:38 +1100 Message-ID: <20160226134138.GD24457@voom.redhat.com> References: <1455897503-11835-1-git-send-email-drjones@redhat.com> <56CF1974.40302@redhat.com> <20160226042449.GJ20657@voom.fritz.box> <20160226130506.aslpteds7wecjdol@hawk.localdomain> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ylS2wUBXLOxYXZFQ" Cc: Laurent Vivier , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, thuth@redhat.com, dgibson@redhat.com, agraf@suse.de, pbonzini@redhat.com, rkrcmar@redhat.com To: Andrew Jones Return-path: Received: from ozlabs.org ([103.22.144.67]:41611 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753153AbcBZNpO (ORCPT ); Fri, 26 Feb 2016 08:45:14 -0500 Content-Disposition: inline In-Reply-To: <20160226130506.aslpteds7wecjdol@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: --ylS2wUBXLOxYXZFQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 26, 2016 at 02:05:06PM +0100, Andrew Jones wrote: > On Fri, Feb 26, 2016 at 03:24:49PM +1100, David Gibson wrote: > > On Thu, Feb 25, 2016 at 04:10:44PM +0100, Laurent Vivier wrote: > > > Hi, > > >=20 > > > based on Drew's work, I've written two small patches to add support of > > > ppc64le host and target. > > >=20 > > > As Drew's series is not merged I don't send yet theses patches, but y= ou > > > can find them here: > > >=20 > > > https://github.com/vivier/kvm-unit-tests/commits/ppc64/endianness-v1 > > >=20 > > > 1- powerpc: allow to build big-endian binaries on little-endian host > > > 2- powerpc: select endianness > > >=20 > > > Patch 2 allows to build and test ppc64le target. > > >=20 > > > I don't know what to do about these two patches: should I wait Drew's > > > series is merged or should I send them now for review? > >=20 > > I think post now. Possibly we can even fold them into Drew's initial > > drop. >=20 > That sounds good to me to. I can pick them up when I post v7. >=20 > >=20 > > Btw, we should know our endianness on entry, so I'm not sure we need > > the automagic FIXUP_ENDIAN stuff. Though maybe it's still the easiest > > way. >=20 > I looked at this a bit too and was under the impression that we're > always going to start in BE, so either the bootloader or the kernel > has to do the wrong endian magic to switch. Since the kernel will have > to know how to do it anyway, in order to deal with a return from an > rtas call, then I was thinking it'd be easiest to leave the bootloader > a simple BE-only branch, and then do the wrong endian stuff in > cstart64.S. It's quite possible I'm missing something though. Sorry, I wasn't clear. LE tests will need code to switch into LE mode (although for the special case of kvm-unit-tests you could potentially put that in the boot_rom.bin). That particular FIX_ENDIAN code, however, uses some magic to work regardless of the endian mode on entry (it starts with an instruction that is harmless on one endian, and a short relative jump in the other endian). Since we know the endian on entry, we shouldn't need that. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ylS2wUBXLOxYXZFQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW0FYSAAoJEGw4ysog2bOSl5AP/iWATF6yN11C9g1GJ9NamATL gPcSHAXwoscpS7r8EKYFOKDGF3OOacxMSsl3qwCJrL91iYNkk+AJBPUQ0UsYj3Lx FD/vg02aVKaffhZlBDCJiEGmmuexXxGOtaKGaFUrh9OBpS8icXO7N/tpLJO8Xqo6 rCkCqY3dtxVW2u+8WKsYtkbr6MtbQ0CLuyvXMdgi67qnBwfHOuwLtKUy/Nmj9xM7 2JSjRdoTP/K2HZw9r0MU7hayylh7wsW1BpTIhNyqQzkTAs7K36uKknLsg5lVnrji pbSPcTWO7seL3GrEdIKy4Y/0937kcE9vNfimiw6VqdbQVf0AT4YLrWbgdvHJXcM6 5UkGMSb8CjMuuhtnhFsiDhxK8XwAucR3+N+tLH0oi29WzB52MwRVWQKonP2YMptz AKw8OTGnniklCsattwA29m7oR844VpT1Epk/BhzMRQpeTiTmN1F112+TkDcPcvG9 6j8466LbM0ZDdShWZFSslPzdt8R1YwOrj4XufAZ0/XXcp7AMcgE3PKjT2HX2+Pyp TeS0DVdGvhRB8dNhmYSVT0+pS4/meFLgN8h8KbCawGKUbW4B7sH0iRaCONPaoCiv lVwQgb9Ha65PDXZh4Np9mR5eYCFD/eV8sarnHRrwY7rhcsSKwo31g3GyFWIbjq0i a7ShPAWBwnMJlZ/yW9NX =D2ye -----END PGP SIGNATURE----- --ylS2wUBXLOxYXZFQ--