From: Borislav Petkov <bp@alien8.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Jörg Rödel" <joro@8bytes.org>,
"Andy Lutomirski" <luto@amacapital.net>, x86-ml <x86@kernel.org>,
"kvm ML" <kvm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] kvm: Make KVM DF intercept configurable
Date: Tue, 1 Mar 2016 23:41:32 +0100 [thread overview]
Message-ID: <20160301224132.GE22677@pd.tnic> (raw)
In-Reply-To: <56D6059D.5050606@redhat.com>
On Tue, Mar 01, 2016 at 10:11:57PM +0100, Paolo Bonzini wrote:
> I just use QEMU's binary translation mode to debug this kind of code (-d
> in_asm is useful and relatively compact (because it only shows loops
> once),
Ha, I had forgotten about "in_asm"! Thanks for reminding me, that's a
really cool feature I'm going to use. With it I see:
----------------
IN:
0x0000000001000000: mov 0xffffffff81cba1f8,%rsp
0x0000000001000008: callq 0x10001a9
----------------
Now, it is obvious that 0xffffffff81cba1f8 is not mapped yet and we're
running from physical addresses. The DF tracepoint shows, in addition,
the previous exception vector causing the DF and I think that's useful.
As an additional debugging aid. Oh, and that doesn't need ept=0 and runs
at full speed.
> or alternatively ept=0. But perhaps... why not. :) It's not like it
> adds overhead.
Yeah, it is off by default and doesn't hurt anyone. And the diff size
is ok, IMHO. Lemme code the Intel side too and see how the whole thing
turns out.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-03-01 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 19:28 [RFC PATCH] kvm: Make KVM DF intercept configurable Borislav Petkov
2016-03-01 21:11 ` Paolo Bonzini
2016-03-01 22:41 ` Borislav Petkov [this message]
2016-03-02 6:45 ` Jan Kiszka
2016-03-02 9:07 ` Borislav Petkov
2016-03-02 9:17 ` Paolo Bonzini
2016-03-02 9:22 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301224132.GE22677@pd.tnic \
--to=bp@alien8.de \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=pbonzini@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox