From: Andrew Jones <drjones@redhat.com>
To: Peter Feiner <pfeiner@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests] powerpc: fix boot_rom.bin build
Date: Fri, 4 Mar 2016 11:31:53 +0100 [thread overview]
Message-ID: <20160304103152.GA3304@localhost.redhat.com> (raw)
In-Reply-To: <1457038529-4577-1-git-send-email-pfeiner@google.com>
On Thu, Mar 03, 2016 at 12:55:29PM -0800, Peter Feiner wrote:
> My powerpc objcopy (version 2.23.52.20130305) did a seek() that
> bash process substitution couldn't handle! I've changed the
> Makefile to do things the old fashioned way.
>
> Signed-off-by: Peter Feiner <pfeiner@google.com>
> ---
> powerpc/Makefile.common | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common
> index 424983e..7818c48 100644
> --- a/powerpc/Makefile.common
> +++ b/powerpc/Makefile.common
> @@ -48,7 +48,8 @@ FLATLIBS = $(libcflat) $(LIBFDT_archive)
>
> $(TEST_DIR)/boot_rom.bin: $(TEST_DIR)/boot_rom.elf
> dd if=/dev/zero of=$@ bs=256 count=1
> - $(OBJCOPY) -O binary $^ >(cat - >>$@)
> + $(OBJCOPY) -O binary $^ $@.suffix
> + cat $@.suffix >> $@
>
> $(TEST_DIR)/boot_rom.elf: CFLAGS = -mbig-endian
> $(TEST_DIR)/boot_rom.elf: $(TEST_DIR)/boot_rom.o
> --
> 2.7.0.rc3.207.g0ac5344
Reviewed-by: Andrew Jones <drjones@redhat.com>
next prev parent reply other threads:[~2016-03-04 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 20:55 [kvm-unit-tests] powerpc: fix boot_rom.bin build Peter Feiner
2016-03-04 10:31 ` Andrew Jones [this message]
2016-03-04 15:28 ` Andrew Jones
2016-03-04 16:54 ` Peter Feiner
2016-03-04 17:09 ` [PATCH kvm-unit-tests v2] " Peter Feiner
2016-03-04 18:34 ` Andrew Jones
2016-03-08 12:49 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304103152.GA3304@localhost.redhat.com \
--to=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pfeiner@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).