From: Andrew Jones <drjones@redhat.com>
To: Peter Feiner <pfeiner@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests] arm: fix parallel build (make -j)
Date: Fri, 4 Mar 2016 12:04:58 +0100 [thread overview]
Message-ID: <20160304110458.GA3641@localhost.redhat.com> (raw)
In-Reply-To: <1457041274-32283-1-git-send-email-pfeiner@google.com>
On Thu, Mar 03, 2016 at 01:41:14PM -0800, Peter Feiner wrote:
> Dependency on asm-offsets.h wasn't made explicit in the Makefiles.
> Worked without -j because non-parallel make builds dependencies in
> declared order.
>
> Signed-off-by: Peter Feiner <pfeiner@google.com>
> ---
> arm/Makefile.common | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arm/Makefile.common b/arm/Makefile.common
> index dd3a0ca..6de82cf 100644
> --- a/arm/Makefile.common
> +++ b/arm/Makefile.common
> @@ -71,3 +71,5 @@ test_cases: $(generated_files) $(tests-common) $(tests)
>
> $(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
> $(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
> +
> +$(TEST_DIR)/selftest.o $(TEST_DIR)/spinlock-test.o $(cstart.o): $(asm-offsets)
You know a project is really growing when you need 'make -j' :-)
How about this patch instead though
-test_cases: $(generated_files) $(tests-common) $(tests)
+test_cases: $(tests-common) $(tests)
+$(patsubst %.flat,%.o,$(tests-common) $(tests)) $(cstart.o): $(generated_files)
Or, hmm, actually any $(TEST_DIR)/ lib/$(TEST_DIR)/ or lib/$(ARCH)/
source file could depend on asm-offsets. So the above probably isn't
sufficient for the long term either.
Thanks,
drew
> --
> 2.7.0.rc3.207.g0ac5344
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-04 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 21:41 [kvm-unit-tests] arm: fix parallel build (make -j) Peter Feiner
2016-03-04 11:04 ` Andrew Jones [this message]
2016-03-04 15:45 ` Paolo Bonzini
2016-03-04 16:28 ` Andrew Jones
2016-03-04 17:03 ` Peter Feiner
2016-03-04 17:04 ` [PATCH kvm-unit-tests v2] " Peter Feiner
2016-03-04 18:34 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304110458.GA3641@localhost.redhat.com \
--to=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pfeiner@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox