From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [kvm-unit-tests] arm: fix parallel build (make -j) Date: Fri, 4 Mar 2016 12:04:58 +0100 Message-ID: <20160304110458.GA3641@localhost.redhat.com> References: <1457041274-32283-1-git-send-email-pfeiner@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, pbonzini@redhat.com To: Peter Feiner Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47460 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbcCDLFG (ORCPT ); Fri, 4 Mar 2016 06:05:06 -0500 Content-Disposition: inline In-Reply-To: <1457041274-32283-1-git-send-email-pfeiner@google.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Mar 03, 2016 at 01:41:14PM -0800, Peter Feiner wrote: > Dependency on asm-offsets.h wasn't made explicit in the Makefiles. > Worked without -j because non-parallel make builds dependencies in > declared order. > > Signed-off-by: Peter Feiner > --- > arm/Makefile.common | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arm/Makefile.common b/arm/Makefile.common > index dd3a0ca..6de82cf 100644 > --- a/arm/Makefile.common > +++ b/arm/Makefile.common > @@ -71,3 +71,5 @@ test_cases: $(generated_files) $(tests-common) $(tests) > > $(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o > $(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o > + > +$(TEST_DIR)/selftest.o $(TEST_DIR)/spinlock-test.o $(cstart.o): $(asm-offsets) You know a project is really growing when you need 'make -j' :-) How about this patch instead though -test_cases: $(generated_files) $(tests-common) $(tests) +test_cases: $(tests-common) $(tests) +$(patsubst %.flat,%.o,$(tests-common) $(tests)) $(cstart.o): $(generated_files) Or, hmm, actually any $(TEST_DIR)/ lib/$(TEST_DIR)/ or lib/$(ARCH)/ source file could depend on asm-offsets. So the above probably isn't sufficient for the long term either. Thanks, drew > -- > 2.7.0.rc3.207.g0ac5344 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html