From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [RFC PATCH 40/45] KVM: arm/arm64: vgic-new: vgic_init: implement vgic_init Date: Fri, 1 Apr 2016 11:00:34 +0200 Message-ID: <20160401090034.GA20224@cbox> References: <1458871508-17279-1-git-send-email-andre.przywara@arm.com> <1458871508-17279-41-git-send-email-andre.przywara@arm.com> <20160331175930.GF4126@cbox> <56FE2F6B.5000508@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andre Przywara , Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Eric Auger Return-path: Received: from mail-wm0-f44.google.com ([74.125.82.44]:34682 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbcDAJAd (ORCPT ); Fri, 1 Apr 2016 05:00:33 -0400 Received: by mail-wm0-f44.google.com with SMTP id p65so16839880wmp.1 for ; Fri, 01 Apr 2016 02:00:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <56FE2F6B.5000508@linaro.org> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Apr 01, 2016 at 10:20:59AM +0200, Eric Auger wrote: > Hi Christoffer, > On 03/31/2016 07:59 PM, Christoffer Dall wrote: > > On Fri, Mar 25, 2016 at 02:05:03AM +0000, Andre Przywara wrote: > >> From: Eric Auger > >> > >> This patch allocates and initializes the data structures used > >> to model the vgic distributor and virtual cpu interfaces. At that > >> stage the number of IRQs and number of virtual CPUs is frozen. > >> > >> The following realy_init functions are kept since they are called from > >> arm.c. However they may disappear in subsequent patches since > >> they are void. > >> > >> vgic_[v2|v3]_enable still is stubbed at this stage. > > > > early init ? > Indeed I can mention those functions also are stubbed. Eventually it may > make sense to remove their call from arm.c but this was not done yet in > this series to avoid touching non vgic code. oh, my comment was to the fact that you wrote realy_init above... :) -Christoffer