From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v2 01/17] arm64: Reuse TCR field definitions for EL1 and EL2 Date: Fri, 15 Apr 2016 16:15:41 +0100 Message-ID: <20160415151541.GO22906@arm.com> References: <1460640065-27658-1-git-send-email-suzuki.poulose@arm.com> <1460640065-27658-2-git-send-email-suzuki.poulose@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, marc.zyngier@arm.com, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu To: Suzuki K Poulose Return-path: Content-Disposition: inline In-Reply-To: <1460640065-27658-2-git-send-email-suzuki.poulose@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On Thu, Apr 14, 2016 at 02:20:49PM +0100, Suzuki K Poulose wrote: > TCR_EL1, TCR_EL2 and VTCR_EL2, all share some field positions > (TG0, ORGN0, IRGN0 and SH0) and their corresponding value definitions. > > This patch makes the TCR_EL1 definitions reusable and uses them for TCR_EL2 > and VTCR_EL2 fields. > > This also fixes a bug where we assume TG0 in {V}TCR_EL2 is 1bit field. > > Cc: Catalin Marinas > Cc: Mark Rutland > Cc: Will Deacon > Cc: Marc Zyngier > Reviewed-by: Christoffer Dall > Signed-off-by: Suzuki K Poulose > --- > arch/arm64/include/asm/kvm_arm.h | 48 ++++++++++--------- > arch/arm64/include/asm/pgtable-hwdef.h | 80 +++++++++++++++++++++++++------- > 2 files changed, 88 insertions(+), 40 deletions(-) Acked-by: Will Deacon Feel free to take this through the kvm-arm tree. Will