From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH v3 6/9] scripts/runtime: skip tests that cannot run Date: Tue, 19 Apr 2016 14:01:57 +0200 Message-ID: <20160419120157.GD11472@potion.brq.redhat.com> References: <1460753571-20732-1-git-send-email-rkrcmar@redhat.com> <1460753571-20732-7-git-send-email-rkrcmar@redhat.com> <20160419070140.jkzyn4y52p7nat6q@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55887 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbcDSMCB (ORCPT ); Tue, 19 Apr 2016 08:02:01 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 68CED7F351 for ; Tue, 19 Apr 2016 12:02:00 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160419070140.jkzyn4y52p7nat6q@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: 2016-04-19 09:01+0200, Andrew Jones: > On Fri, Apr 15, 2016 at 10:52:48PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99= wrote: > > A case where QEMU won't run the kernel should be considered as skip= ped. > > Hyper-V tests used to FAIL on old QEMUs. The infamous QEMU=3D/dev/= null > > FAIL streak is covered too. > >=20 > > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > > --- > > scripts/runtime.bash | 6 ++++++ > > 1 file changed, 6 insertions(+) > >=20 > > diff --git a/scripts/runtime.bash b/scripts/runtime.bash > > index ed073721216c..4f29a59307f3 100644 > > --- a/scripts/runtime.bash > > +++ b/scripts/runtime.bash > > @@ -39,6 +39,12 @@ function run() > > fi > > done > > =20 > > + cmdline=3D"TIMEOUT=3D$timeout ACCEL=3D$accel $RUNTIME_arch_run= /dev/null -smp $smp $opts" > > + eval $cmdline |& grep -q "could not load kernel" || { > > + echo "skip $1 (QEMU won't run)" > > + return 2 > > + } >=20 > This doesn't seem to work for arm; qemu just hangs with a /dev/null > kernel. Thanks, I'll be using _NO_FILE_4Uhere_, like scripts/runtime does. > Also, this will echo an extra command line per test to the > test.log. Changing the logging mechanism in [8/9] got rid of it, but I forgot to mention it. Patches need a bit of reshufling to make it logical ... > $(TEST_DIR)/run scripts already do some qemu testing to make sure the= ir > machine model and testdevs are available. If not, they return 2. Isn'= t > that good enough? QEMU can fail, because we appended something that isn't supported, like hyperv tests do. Then the test is a FAIL. > Don't we just need to add a '$ret =3D 2' condition = in > run()? What if we changed that return value to 77? The test wasn't really run= =2E