From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH v3 9/9] run_tests: log stderr
Date: Tue, 19 Apr 2016 14:13:35 +0200
Message-ID: <20160419121335.GE11472@potion.brq.redhat.com>
References: <1460753571-20732-1-git-send-email-rkrcmar@redhat.com>
 <1460753571-20732-10-git-send-email-rkrcmar@redhat.com>
 <20160419072602.blvi6ag7dxyeong6@hawk.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58625 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752304AbcDSMNj (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 19 Apr 2016 08:13:39 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 659D97F351
	for <kvm@vger.kernel.org>; Tue, 19 Apr 2016 12:13:38 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20160419072602.blvi6ag7dxyeong6@hawk.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2016-04-19 09:26+0200, Andrew Jones:
> On Fri, Apr 15, 2016 at 10:52:51PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99=
 wrote:
>> After recent changes to logging, seeing it all the time doesn't help=
=2E
>> We could print one line in summary if stderr is missed.
>=20
> I miss it already :-)
>=20
> I like stderr coming to the terminal from which run_tests.sh is run,
> because it should be rare and probably important to see. I'd rather
> this patch at least include the one summary line now, rather than
> wait and see if we want it later.

Messages in stderr aren't rare, though ... we see several of them on
every batch:

warning: host doesn't support requested feature: CPUID.80000001H:ECX.sv=
m [bit 2]
warning: host doesn't support requested feature: CPUID.80000001H:ECX.sv=
m [bit 2]
warning: host doesn't support requested feature: CPUID.01H:ECX.vmx [bit=
 5]

(Warnings already screw up our FAIL heuristic, so we'd better do
 something with them ...)

>                                   Or maybe just drop this patch?

I'll drop this patch, it was borderline acceptable and making the
summary bearable would might be out of my league.

>> diff --git a/run_tests.sh b/run_tests.sh
>> @@ -47,6 +47,7 @@ while getopts "g:hv" opt; do
>> +RUNTIME_log_stderr=3D'test.log'
>> diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh
>> @@ -70,6 +70,7 @@ generate_test ()
>> +	echo "RUNTIME_log_stderr=3D>(cat >&2)"
>=20
> No need for the single quotes like RUNTIME_log_stdout has? Or
> does RUNTIME_log_stdout not need them?

*evil laugh*, both of them need quotes just where they are.

RUNTIME_log_stdout is used in a subshell that wouldn't have access to
the fd if we evaluated it here.
RUNTIME_log_stderr has to be evaluated into the fd here, because it
wouldn't be evaluated in the future.

(Take a while to apprectiate this hellspawn.)

>> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
>> @@ -61,7 +61,8 @@ function run()
>> -    summary=3D$(eval $cmdline > >(eval "tee -a $RUNTIME_log_stdout"=
 | extract_summary))
>> +    summary=3D$(eval $cmdline > >(eval "tee -a $RUNTIME_log_stdout"=
 | extract_summary) \
>> +                            2>> $RUNTIME_log_stderr)