From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH kvm-unit-tests v3 0/9] Improve the output of test runners Date: Tue, 19 Apr 2016 14:14:47 +0200 Message-ID: <20160419121447.GA10102@potion.brq.redhat.com> References: <1460753571-20732-1-git-send-email-rkrcmar@redhat.com> <20160419073144.4pwywy5fvii6ixd7@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38723 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752304AbcDSMOv (ORCPT ); Tue, 19 Apr 2016 08:14:51 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A072B81F07 for ; Tue, 19 Apr 2016 12:14:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160419073144.4pwywy5fvii6ixd7@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: 2016-04-19 09:31+0200, Andrew Jones: > On Fri, Apr 15, 2016 at 10:52:42PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99= wrote: >> v2: http://www.spinics.net/lists/kvm/msg125429.html >>=20 >> mkstandalone is using generic code now, so v3 focuses on the output >> again. And the output looks like in v2. Since v2, I've >> * removed svm-disabled [3/7] >> * reworked summary reporting [8/9] (it's a nice feature, but still u= gly) >> * turned all cases when QEMU won't run the test into SKIP [6/7] >> * preserved check_param (it's not used, though) >> * stopped returning 77 on all SKIPs [7/7] (a sacrifice to prevent >> another refactoring of our scripts) >>=20 >> I didn't manage to look at the comment from Luk=C3=A1=C5=A1's patche= s, but I don't >> expect that v3 will be the last one ... a lot has changed since v2. >=20 > Lukas' comment was that the skip due to a test needing KVM (i.e. not > possible to run with TCG) should get a more informative summary. He > wanted something along the lines of 'kvm test only, and this system > doesn't have kvm', rather than just 'kvm only'. >=20 > Oh, actually those summaries are arm and powerpc run script summaries= , > not common runtime. They could still be improved with this series :-) Thanks for reviews ... I'll handle it.