Re: [PATCH kvm-unit-tests] cscope: fix database generation

["Radim Krčmář" <rkrcmar@redhat.com>]

2016-04-19 13:08-0400, Bandan Das:
> Andrew Jones <drjones@redhat.com> writes:
>> On Mon, Apr 18, 2016 at 07:04:55PM -0400, Bandan Das wrote:
>>> 
>>> The cscope.files that we generate doesn't include all
>>> source files that are potentially interesting. We should
>>> include all $(ARCH)es  and not the just the one configure
>>> finds. Moreover, $(ARCH) expands to x86_64 which is not the
>>> correct path for x86 sources. Generate cscope.files by searching
>>> for all files starting from root.
>>
>> No thanks :-) I'd rather not get hits for x86 and powerpc when
> 
> I don't think that's a good idea. Just because you don't like to
> see x86 bits when jumping around in arm code doesn't mean you should
> hide all references to a given function. And if the arm code is
> segregated enough that there are no common functions, you won't
> see them anyway. 
> [...]                                               But please let's
> not make it difficult to write arm/powerpc tests just because someone's on
> x86 :)

In the kernel, environment can override configuration, so you'd do

  % ARCH=arm make cscope

and it doesn't matter what arch is being compiled.  I think this would
be a better solution for kvm-unit-tests too.

I agree with Drew that other arches would mostly clutter searches if
they were included by default, but we can also add a rule in case
indexing all arches is desired (like when changing the prototype of some
generic function?).