From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH kvm-unit-tests] cscope: fix database generation Date: Tue, 19 Apr 2016 20:38:45 +0200 Message-ID: <20160419183845.GB10102@potion.brq.redhat.com> References: <20160419052510.t2xkdunwjmwvry77@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Jones , KVM , Paolo Bonzini To: Bandan Das Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53837 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932243AbcDSSit (ORCPT ); Tue, 19 Apr 2016 14:38:49 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BD0FD461E2 for ; Tue, 19 Apr 2016 18:38:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: 2016-04-19 13:08-0400, Bandan Das: > Andrew Jones writes: >> On Mon, Apr 18, 2016 at 07:04:55PM -0400, Bandan Das wrote: >>> >>> The cscope.files that we generate doesn't include all >>> source files that are potentially interesting. We should >>> include all $(ARCH)es and not the just the one configure >>> finds. Moreover, $(ARCH) expands to x86_64 which is not the >>> correct path for x86 sources. Generate cscope.files by searching >>> for all files starting from root. >> >> No thanks :-) I'd rather not get hits for x86 and powerpc when > > I don't think that's a good idea. Just because you don't like to > see x86 bits when jumping around in arm code doesn't mean you should > hide all references to a given function. And if the arm code is > segregated enough that there are no common functions, you won't > see them anyway. > [...] But please let's > not make it difficult to write arm/powerpc tests just because someone's on > x86 :) In the kernel, environment can override configuration, so you'd do % ARCH=arm make cscope and it doesn't matter what arch is being compiled. I think this would be a better solution for kvm-unit-tests too. I agree with Drew that other arches would mostly clutter searches if they were included by default, but we can also add a rule in case indexing all arches is desired (like when changing the prototype of some generic function?).