From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
james.hogan@imgtec.com, mingo@redhat.com,
linux-mips@linux-mips.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David Hildenbrand" <dahi@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, "Paul Mackerras" <paulus@samba.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v4 2/2] KVM: move vcpu id checking to archs
Date: Fri, 22 Apr 2016 12:22:10 +0200 [thread overview]
Message-ID: <20160422122210.50450345.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20160422112538.41b23a9d@bahia.huguette.org>
On Fri, 22 Apr 2016 11:25:38 +0200
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> On Thu, 21 Apr 2016 19:36:11 +0200
> Radim Krčmář <rkrcmar@redhat.com> wrote:
> > > For other architectures, it is simply KVM_MAX_VCPUS.
> >
> > (Other architectures would not implement the capability.)
> >
>
> So this would be KVM_CAP_PPC_MAX_VCPU_ID ?
>
> > >> I think this would also clarify the connection between VCPU limit and
> > >> VCPU_ID limit. Or is a boolean cap better?
> > >>
> > >
> > > Well, I'm not fan of adding a generic API to handle a corner case...
> >
> > I don't like it either, but I think that introducing the capability is
> > worth avoided problems.
> >
>
> I admit that having separate capabilities for the number of vcpus and the
> maximum vcpu id fixes the confusion once and for all.
Yes, and I think that the new max_vpcu_id cap should be generic for
that reason.
next prev parent reply other threads:[~2016-04-22 10:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 14:14 [PATCH v4 0/2] let archs decide for vcpu ids Greg Kurz
2016-04-21 14:15 ` [PATCH v4 1/2] KVM: remove NULL return path for vcpu ids >= KVM_MAX_VCPUS Greg Kurz
2016-04-21 14:17 ` David Hildenbrand
2016-04-21 14:30 ` Greg Kurz
2016-04-26 7:44 ` Cornelia Huck
2016-04-27 9:40 ` Gerg Kurz
2016-04-27 14:40 ` Radim Krčmář
2016-04-21 14:20 ` [PATCH v4 2/2] KVM: move vcpu id checking to archs Greg Kurz
2016-04-21 16:00 ` Radim Krčmář
2016-04-21 16:45 ` Greg Kurz
2016-04-21 17:36 ` Radim Krčmář
2016-04-22 9:25 ` Greg Kurz
2016-04-22 10:22 ` Cornelia Huck [this message]
2016-04-22 11:19 ` Igor Mammedov
2016-04-22 13:48 ` Radim Krčmář
2016-04-22 13:40 ` Radim Krčmář
2016-04-22 14:50 ` Greg Kurz
2016-04-25 14:15 ` Radim Krčmář
2016-04-25 14:30 ` Greg Kurz
2016-04-22 9:21 ` Wei Yang
2016-04-22 9:30 ` Greg Kurz
2016-04-23 0:51 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422122210.50450345.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=gkurz@linux.vnet.ibm.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=qemu-ppc@nongnu.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox