From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] KVM: x86: fix ordering of cr0 initialization code in vmx_cpu_reset Date: Sat, 23 Apr 2016 07:18:10 +0900 Message-ID: <20160422221810.GA10089@kroah.com> References: <1461351363-28094-1-git-send-email-brogers@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, namit@cs.technion.ac.il, stable@vger.kernel.org To: Bruce Rogers Return-path: Content-Disposition: inline In-Reply-To: <1461351363-28094-1-git-send-email-brogers@suse.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Fri, Apr 22, 2016 at 12:56:03PM -0600, Bruce Rogers wrote: > Commit d28bc9dd25ce reversed the order of two lines which initialize cr0, > allowing the current (old) cr0 value to mess up vcpu initialization. > This was observed in the checks for cr0 X86_CR0_WP bit in the context of > kvm_mmu_reset_context(). Besides, setting vcpu->arch.cr0 after vmx_set_cr0() > is completely redundant. Change the order back to ensure proper vcpu > initialization. > > The combination of booting with ovmf firmware when guest vcpus > 1 and kvm's > ept=N option being set results in a VM-entry failure. This patch fixes that. > > Signed-off-by: Bruce Rogers > --- > arch/x86/kvm/vmx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly.