From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v4 1/2] KVM: remove NULL return path for vcpu ids >= KVM_MAX_VCPUS Date: Tue, 26 Apr 2016 09:44:58 +0200 Message-ID: <20160426094458.03685ae5.cornelia.huck@de.ibm.com> References: <146124809455.32509.15232948272580716135.stgit@bahia.huguette.org> <146124810201.32509.2946887043729554992.stgit@bahia.huguette.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Paolo Bonzini , james.hogan@imgtec.com, mingo@redhat.com, linux-mips@linux-mips.org, kvm@vger.kernel.org, rkrcmar@redhat.com, linux-kernel@vger.kernel.org, David Hildenbrand , qemu-ppc@nongnu.org, Paul Mackerras , David Gibson To: Greg Kurz Return-path: In-Reply-To: <146124810201.32509.2946887043729554992.stgit@bahia.huguette.org> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: List-Id: kvm.vger.kernel.org On Thu, 21 Apr 2016 16:15:05 +0200 Greg Kurz wrote: > Commit c896939f7cff ("KVM: use heuristic for fast VCPU lookup by id") added > a return path that prevents vcpu ids to exceed KVM_MAX_VCPUS. This is a > problem for powerpc where vcpu ids can grow up to 8*KVM_MAX_VCPUS. > > This patch simply reverses the logic so that we only try fast path if the > vcpu id can be tried as an index in kvm->vcpus[]. The slow path is not > affected by the change. > > Signed-off-by: Greg Kurz > --- > include/linux/kvm_host.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Cornelia Huck