From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH kernel] vfio_iommu_spapr_tce: Remove unneeded iommu_group_get_iommudata Date: Thu, 28 Apr 2016 12:33:00 -0600 Message-ID: <20160428123300.34dfff51@t450s.home> References: <1460091281-14664-1-git-send-email-aik@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linuxppc-dev@lists.ozlabs.org, David Gibson , kvm@vger.kernel.org To: Alexey Kardashevskiy Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44074 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751932AbcD1SdD (ORCPT ); Thu, 28 Apr 2016 14:33:03 -0400 In-Reply-To: <1460091281-14664-1-git-send-email-aik@ozlabs.ru> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 8 Apr 2016 14:54:41 +1000 Alexey Kardashevskiy wrote: > This removes iommu_group_get_iommudata() as the result is never used. > As this is a minor cleanup, no change in behavior is expected. > > Signed-off-by: Alexey Kardashevskiy > --- > drivers/vfio/vfio_iommu_spapr_tce.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c > index 0582b72..6419566 100644 > --- a/drivers/vfio/vfio_iommu_spapr_tce.c > +++ b/drivers/vfio/vfio_iommu_spapr_tce.c > @@ -331,14 +331,12 @@ static void tce_iommu_free_table(struct iommu_table *tbl); > static void tce_iommu_release(void *iommu_data) > { > struct tce_container *container = iommu_data; > - struct iommu_table_group *table_group; > struct tce_iommu_group *tcegrp; > long i; > > while (tce_groups_attached(container)) { > tcegrp = list_first_entry(&container->group_list, > struct tce_iommu_group, next); > - table_group = iommu_group_get_iommudata(tcegrp->grp); > tce_iommu_detach_group(iommu_data, tcegrp->grp); > } > Applied to next with David's R-b for v4.7. Thanks, Alex