From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>, KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
"Jens Freimann" <jfrei@linux.vnet.ibm.com>,
"David Hildenbrand" <dahi@linux.vnet.ibm.com>
Subject: Re: [PATCH/RFC] KVM: halt_polling: provide a way to qualify wakeups during poll
Date: Mon, 2 May 2016 13:46:27 +0200 [thread overview]
Message-ID: <20160502134627.71319e1b.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1462185753-14634-1-git-send-email-borntraeger@de.ibm.com>
On Mon, 2 May 2016 12:42:33 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> @@ -2038,14 +2039,16 @@ out:
> if (block_ns <= vcpu->halt_poll_ns)
> ;
> /* we had a long block, shrink polling */
> - else if (vcpu->halt_poll_ns && block_ns > halt_poll_ns)
> + else if (!vcpu_valid_wakeup(vcpu) ||
> + (vcpu->halt_poll_ns && block_ns > halt_poll_ns))
> shrink_halt_poll_ns(vcpu);
> /* we had a short halt and our poll time is too small */
> else if (vcpu->halt_poll_ns < halt_poll_ns &&
> - block_ns < halt_poll_ns)
> + block_ns < halt_poll_ns && vcpu_valid_wakeup(vcpu))
Isn't that vcpu_valid_wakeup() check superflous, as we have collected
all !vcpu_valid_wakeup() cases in the previous if?
> grow_halt_poll_ns(vcpu);
> } else
> vcpu->halt_poll_ns = 0;
> + vcpu_reset_wakeup(vcpu);
>
> trace_kvm_vcpu_wakeup(block_ns, waited);
> }
next prev parent reply other threads:[~2016-05-02 11:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 10:42 [PATCH/RFC] KVM: halt_polling: provide a way to qualify wakeups during poll Christian Borntraeger
2016-05-02 10:45 ` David Hildenbrand
2016-05-02 11:46 ` Cornelia Huck [this message]
2016-05-02 11:50 ` Christian Borntraeger
2016-05-02 13:34 ` Radim Krčmář
2016-05-02 14:30 ` Christian Borntraeger
2016-05-02 15:25 ` Radim Krčmář
2016-05-03 8:55 ` Christian Borntraeger
2016-05-02 19:44 ` David Matlack
2016-05-03 8:46 ` Christian Borntraeger
2016-05-03 5:42 ` Wanpeng Li
2016-05-03 7:00 ` Christian Borntraeger
2016-05-03 9:19 ` Cornelia Huck
2016-05-10 13:54 ` Paolo Bonzini
2016-05-03 7:50 ` Wanpeng Li
2016-05-03 8:00 ` Cornelia Huck
2016-05-03 8:00 ` Christian Borntraeger
2016-05-03 8:48 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502134627.71319e1b.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox