public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu
Date: Wed, 4 May 2016 08:40:21 +0200	[thread overview]
Message-ID: <20160504084021.18cf98f0.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1462342376-16065-2-git-send-email-rppt@linux.vnet.ibm.com>

On Wed,  4 May 2016 09:12:56 +0300
Mike Rapoport <rppt@linux.vnet.ibm.com> wrote:

> /dev/cpu is only available on x86 with certain modules (e.g. msr) enabled.
> Using /proc/cpuinfo to get processors count is more portable.
> 
> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
> ---
>  tools/virtio/ringtest/run-on-all.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/virtio/ringtest/run-on-all.sh b/tools/virtio/ringtest/run-on-all.sh
> index 52b0f71..38ccfa3 100755
> --- a/tools/virtio/ringtest/run-on-all.sh
> +++ b/tools/virtio/ringtest/run-on-all.sh
> @@ -3,10 +3,10 @@
>  #use last CPU for host. Why not the first?
>  #many devices tend to use cpu0 by default so
>  #it tends to be busier
> -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1)
> +HOST_AFFINITY=$(($(grep -c processor /proc/cpuinfo) - 1))
>  
>  #run command on all cpus
> -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n);
> +for cpu in $(seq 0 $HOST_AFFINITY)
>  do
>  	#Don't run guest and host on same CPU
>  	#It actually works ok if using signalling

As you're touching this anyway: Is there any way to avoid the
architecture-specific /proc/cpuinfo and do whatever lscpu does?


  reply	other threads:[~2016-05-04  6:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04  6:12 [PATCH] tools/virtio/ringtest: add usage example to README Mike Rapoport
2016-05-04  6:12 ` [PATCH] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu Mike Rapoport
2016-05-04  6:40   ` Cornelia Huck [this message]
2016-05-04  7:59     ` [PATCH v2] " Mike Rapoport
2016-05-04  8:14       ` Cornelia Huck
2016-05-04 10:15         ` [PATCH v3] " Mike Rapoport
2016-05-04 10:24           ` Cornelia Huck
2016-05-24 12:41           ` Mike Rapoport
2016-06-06  6:55             ` Mike Rapoport
2016-06-06  6:55             ` Mike Rapoport
     [not found]             ` <201606060656.u566rhsn006487@mx0a-001b2d01.pphosted.com>
2016-06-06 13:57               ` Michael S. Tsirkin
2016-05-24 12:41 ` [PATCH] tools/virtio/ringtest: add usage example to README Mike Rapoport
2016-06-06  6:56   ` Mike Rapoport
2016-06-06  6:56   ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160504084021.18cf98f0.cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox