From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] vfio: platform: use vfio_iommu_group_get/put Date: Mon, 9 May 2016 09:32:38 -0600 Message-ID: <20160509093238.3901f0b7@t450s.home> References: <1462788103-19906-1-git-send-email-van.freenix@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: b.reynal@virtualopensystems.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Peng Fan Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56892 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbcEIPcj (ORCPT ); Mon, 9 May 2016 11:32:39 -0400 In-Reply-To: <1462788103-19906-1-git-send-email-van.freenix@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 9 May 2016 18:01:43 +0800 Peng Fan wrote: > Use vfio_iommu_group_get and vfio_iommu_group_put, but not > iommu_group_get or iommu_group_put. I assume you're trying to duplicate the vfio_pci changes from commit 03a76b60f8ba to enable no-iommu mode. That would be really relevant information for the commit log. > > Signed-off-by: Peng Fan > Cc: Baptiste Reynal > Cc: Alex Williamson > --- > drivers/vfio/platform/vfio_platform_common.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c > index e65b142..582885e 100644 > --- a/drivers/vfio/platform/vfio_platform_common.c > +++ b/drivers/vfio/platform/vfio_platform_common.c > @@ -561,7 +561,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev, > > vdev->device = dev; > > - group = iommu_group_get(dev); > + group = vfio_iommu_group_get(dev); > if (!group) { > pr_err("VFIO: No IOMMU group for device %s\n", vdev->name); > return -EINVAL; > @@ -569,7 +569,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev, > > ret = vfio_add_group_dev(dev, &vfio_platform_ops, vdev); > if (ret) { > - iommu_group_put(group); > + vfio_iommu_group_put(group); > return ret; > } > > @@ -589,7 +589,7 @@ struct vfio_platform_device *vfio_platform_remove_common(struct device *dev) > > if (vdev) { > vfio_platform_put_reset(vdev); > - iommu_group_put(dev->iommu_group); > + vfio_iommu_group_put(dev->iommu_group, dev); > } > > return vdev;