From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yang Subject: Re: [kvm-unit-tests PATCH 1/2] arm/arm64: Makefile cleanup Date: Mon, 9 May 2016 22:24:10 +0000 Message-ID: <20160509222410.GC21601@vultr.guest> References: <1462802466-22634-1-git-send-email-drjones@redhat.com> <1462802466-22634-2-git-send-email-drjones@redhat.com> Reply-To: Wei Yang Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, lvivier@redhat.com, thuth@redhat.com, richard.weiyang@gmail.com To: Andrew Jones Return-path: Received: from mail-pa0-f68.google.com ([209.85.220.68]:32914 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbcEIWYO (ORCPT ); Mon, 9 May 2016 18:24:14 -0400 Received: by mail-pa0-f68.google.com with SMTP id gh9so16509671pac.0 for ; Mon, 09 May 2016 15:24:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1462802466-22634-2-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 09, 2016 at 04:01:05PM +0200, Andrew Jones wrote: >This does the same cleanup as 'x86: Makefile refine' > >Signed-off-by: Andrew Jones Reviewed-by: Wei Yang >--- > arm/Makefile.common | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/arm/Makefile.common b/arm/Makefile.common >index 9a2d61fc88a27..51d2cf1690cae 100644 >--- a/arm/Makefile.common >+++ b/arm/Makefile.common >@@ -24,6 +24,9 @@ CFLAGS += -Wextra > CFLAGS += -O2 > CFLAGS += -I lib -I lib/libfdt > >+# We want to keep intermediate files: %.elf and %.o >+.PRECIOUS: %.elf %.o >+ > asm-offsets = lib/$(ARCH)/asm-offsets.h > include scripts/asm-offsets.mak > >@@ -48,7 +51,7 @@ start_addr := $(shell printf "%x\n" $$(( $(phys_base) + $(kernel_offset) ))) > > FLATLIBS = $(libcflat) $(LIBFDT_archive) $(libgcc) $(libeabi) > %.elf: LDFLAGS = $(CFLAGS) -nostdlib >-%.elf: %.o $(FLATLIBS) arm/flat.lds >+%.elf: %.o $(FLATLIBS) arm/flat.lds $(cstart.o) > $(CC) $(LDFLAGS) -o $@ \ > -Wl,-T,arm/flat.lds,--build-id=none,-Ttext=$(start_addr) \ > $(filter %.o, $^) $(FLATLIBS) >@@ -69,7 +72,4 @@ generated_files = $(asm-offsets) > > test_cases: $(generated_files) $(tests-common) $(tests) > >-$(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o >-$(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o >- > $(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets) >-- >2.4.11 -- Wei Yang Help you, Help me