From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: "James Hogan" <james.hogan@imgtec.com>,
"Paul Burton" <paul.burton@imgtec.com>,
"Manuel Lauss" <manuel.lauss@gmail.com>,
"Jayachandran C." <jchandra@broadcom.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
linux-mips@linux-mips.org, kvm@vger.kernel.org
Subject: Re: [PATCH 0/7] MIPS: Add extended ASID support
Date: Tue, 10 May 2016 09:34:44 +0200 [thread overview]
Message-ID: <20160510073444.GA16402@linux-mips.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1605092041200.6794@tp.orcam.me.uk>
On Mon, May 09, 2016 at 08:56:51PM +0100, Maciej W. Rozycki wrote:
> Yes, but these are not legacy architectures, are they? Since you've got
> bits set across Config registers you don't need to resort to poking at
> other registers. Although there are exceptions like PABITS and SEGBITS
> (we ought to handle this one day actually, for correct unaligned access
> emulation -- right now you get a repeated AdEL exception in emulation code
> for what originally was an unaligned out of range kernel XKPHYS access,
> making it a big pain to debug; I've had a hack for this since 2.4 days,
> but it should be done properly).
Yeah, it's simply an implementation guided by the SISO principle. Shit in,
shit out. The issue you're having rarely hurts and if a simple hack can
solve it I'm in principle open to consider it for merging.
> In the old days pretty much nothing was recorded in the single Config
> register (very old chips didn't even have that -- you had to size caches
> manually for example), but stuff could often be determined via other
> means, sometimes (like probably here) without detailed checks on PRId.
Sizing the R4000/R4400 second level cache for example. I'd call that
taking the RISC design principle to the edge :-)
Ralf
next prev parent reply other threads:[~2016-05-10 7:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 13:36 [PATCH 0/7] MIPS: Add extended ASID support James Hogan
2016-05-06 13:36 ` [PATCH 1/7] MIPS: KVM/locore.S: Don't preserve host ASID around vcpu_run James Hogan
2016-05-09 14:22 ` Paolo Bonzini
2016-05-09 15:30 ` Ralf Baechle
2016-05-09 19:42 ` James Hogan
2016-05-06 13:36 ` [PATCH 2/7] MIPS: Add & use CP0_EntryHi ASID definitions James Hogan
2016-05-06 13:36 ` [PATCH 3/7] MIPS: KVM: Abstract guest ASID mask James Hogan
2016-05-06 13:36 ` [PATCH 4/7] MIPS: KVM/locore.S: Only preserve callee saved registers James Hogan
2016-05-06 13:36 ` [PATCH 5/7] MIPS: KVM/locore.S: Relax noat James Hogan
2016-05-06 13:36 ` [PATCH 6/7] MIPS: Retrieve ASID masks using function accepting struct cpuinfo_mips James Hogan
2016-05-06 13:36 ` [PATCH 7/7] MIPS: Support extended ASIDs James Hogan
2016-05-09 13:23 ` [PATCH 0/7] MIPS: Add extended ASID support Ralf Baechle
2016-05-09 17:01 ` Maciej W. Rozycki
2016-05-09 19:04 ` James Hogan
2016-05-09 19:56 ` Maciej W. Rozycki
2016-05-09 19:59 ` James Hogan
2016-05-10 7:34 ` Ralf Baechle [this message]
2016-05-10 8:55 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510073444.GA16402@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=james.hogan@imgtec.com \
--cc=jchandra@broadcom.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@imgtec.com \
--cc=manuel.lauss@gmail.com \
--cc=paul.burton@imgtec.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox