From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: [PATCH 0/7] MIPS: Add extended ASID support Date: Tue, 10 May 2016 09:34:44 +0200 Message-ID: <20160510073444.GA16402@linux-mips.org> References: <1462541784-22128-1-git-send-email-james.hogan@imgtec.com> <20160509132315.GA28818@linux-mips.org> <20160509190442.GC23699@jhogan-linux.le.imgtec.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: James Hogan , Paul Burton , Manuel Lauss , "Jayachandran C." , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , linux-mips@linux-mips.org, kvm@vger.kernel.org To: "Maciej W. Rozycki" Return-path: Received: from eddie.linux-mips.org ([148.251.95.138]:33682 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbcEJHew (ORCPT ); Tue, 10 May 2016 03:34:52 -0400 Received: from localhost.localdomain ([127.0.0.1]:57440 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27028566AbcEJHetqUmUv (ORCPT ); Tue, 10 May 2016 09:34:49 +0200 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 09, 2016 at 08:56:51PM +0100, Maciej W. Rozycki wrote: > Yes, but these are not legacy architectures, are they? Since you've got > bits set across Config registers you don't need to resort to poking at > other registers. Although there are exceptions like PABITS and SEGBITS > (we ought to handle this one day actually, for correct unaligned access > emulation -- right now you get a repeated AdEL exception in emulation code > for what originally was an unaligned out of range kernel XKPHYS access, > making it a big pain to debug; I've had a hack for this since 2.4 days, > but it should be done properly). Yeah, it's simply an implementation guided by the SISO principle. Shit in, shit out. The issue you're having rarely hurts and if a simple hack can solve it I'm in principle open to consider it for merging. > In the old days pretty much nothing was recorded in the single Config > register (very old chips didn't even have that -- you had to size caches > manually for example), but stuff could often be determined via other > means, sometimes (like probably here) without detailed checks on PRId. Sizing the R4000/R4400 second level cache for example. I'd call that taking the RISC design principle to the edge :-) Ralf