From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH v3 9/9] run_tests: log stderr
Date: Tue, 10 May 2016 14:47:31 +0200
Message-ID: <20160510124731.GD12472@potion>
References: <1460753571-20732-1-git-send-email-rkrcmar@redhat.com>
 <1460753571-20732-10-git-send-email-rkrcmar@redhat.com>
 <5731C8F9.3020204@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, Andrew Jones <drjones@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:59468 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751926AbcEJMrf (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 10 May 2016 08:47:35 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 5DAD3800A8
	for <kvm@vger.kernel.org>; Tue, 10 May 2016 12:47:34 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <5731C8F9.3020204@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2016-05-10 13:41+0200, Paolo Bonzini:
> On 15/04/2016 22:52, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
>>  	echo "exec {stdout}>&1"
>>  	echo "RUNTIME_log_stdout=3D'>(cat >&\$stdout)'"
>> +	echo "RUNTIME_log_stderr=3D>(cat >&2)"
>> =20
>>  	cat scripts/runtime.bash
>> =20
>> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
>> index fc4be91d8727..ff2d98b547b5 100644
>> --- a/scripts/runtime.bash
>> +++ b/scripts/runtime.bash
>> @@ -61,7 +61,8 @@ function run()
>> =20
>>      # extra_params in the config file may contain backticks that ne=
ed to be
>>      # expanded, so use eval to start qemu.  Same for $RUNTIME_log_s=
tdout.
>> -    summary=3D$(eval $cmdline > >(eval "tee -a $RUNTIME_log_stdout"=
 | extract_summary))
>> +    summary=3D$(eval $cmdline > >(eval "tee -a $RUNTIME_log_stdout"=
 | extract_summary) \
>> +                            2>> $RUNTIME_log_stderr)
>=20
> Whoa, so this uses the outer eval?

No, RUNTIME_log_stderr is evaluated only at the time of definition,
which makes it inconsistent with RUNTIME_log_stdout.

>                                     Perhaps the 2>> should move befor=
e
> the >.

I will drop this patch ... it's too insane and Drew liked stderr in
=2E/run_tests.sh output.  Sorry.