public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH v3 8/9] run_tests: print summary
Date: Tue, 10 May 2016 17:31:34 +0200	[thread overview]
Message-ID: <20160510153134.GE12472@potion> (raw)
In-Reply-To: <5731F10D.5030300@redhat.com>

2016-05-10 16:32+0200, Paolo Bonzini:
> On 10/05/2016 14:41, Radim Krčmář wrote:
>>> > eval $cmdline 2>> $RUNTIME_log_stderr \
>>> >               | eval tee -a "$RUNTIME_log_stdout" | extract_summary
>>> > 
>>> > Anything I am missing?
>>> > 
>>>>> >>>      ret=$?
>> Simple pipeline would not return the return value of `eval $cmdline`, so
>> it seemed nicer with a redirection.
> 
> Right...  Two more attempts:
> 
>     eval "$cmdline 2>> $RUNTIME_log_stderr
>                    > >(tee -a $RUNTIME_log_stdout | extract_summary)"
> 
>     (eval $cmdline) 2> >($RUNTIME_cmd_stderr)
>                      > >(tee >($RUNTIME_cmd_stdout) | extract_summary)"
> 
> (The latter requiring an extra useless uses of cat for test.log).
> 
> Would any of these work fine?

The former one works.  The latter would work if $RUNTIME_cmd_stdout
accepted $kernel as an argument.

  summary=$(eval $cmdline
            > >(tee >(RUNTIME_log_stdout $kernel) | extract_summary))

Is that acceptable?
(I will gladly degrade performance to have less code in eval.)

Thanks.

  reply	other threads:[~2016-05-10 15:31 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15 20:52 [PATCH kvm-unit-tests v3 0/9] Improve the output of test runners Radim Krčmář
2016-04-15 20:52 ` [PATCH v3 1/9] lib/report: allow test skipping Radim Krčmář
2016-04-19  6:26   ` Andrew Jones
2016-04-15 20:52 ` [PATCH v3 2/9] x86/*: report skipped tests Radim Krčmář
2016-04-19  6:34   ` Andrew Jones
2016-04-19 11:51     ` Radim Krčmář
2016-04-15 20:52 ` [PATCH v3 3/9] x86/unittests: remove svm-disabled Radim Krčmář
2016-04-15 20:52 ` [PATCH v3 4/9] x86/pmu: expect failure with nmi_watchdog Radim Krčmář
2016-04-19  6:44   ` Andrew Jones
2016-04-19 11:57     ` Radim Krčmář
2016-04-19 13:46       ` Andrew Jones
2016-04-15 20:52 ` [PATCH v3 5/9] lib/report: don't print 0 failed tests Radim Krčmář
2016-04-19  6:45   ` Andrew Jones
2016-04-15 20:52 ` [PATCH v3 6/9] scripts/runtime: skip tests that cannot run Radim Krčmář
2016-04-19  7:01   ` Andrew Jones
2016-04-19 12:01     ` Radim Krčmář
2016-04-15 20:52 ` [PATCH v3 7/9] scripts/runtime: consolidate summary tags Radim Krčmář
2016-04-19  7:04   ` Andrew Jones
2016-04-15 20:52 ` [PATCH v3 8/9] run_tests: print summary Radim Krčmář
2016-04-19  7:19   ` Andrew Jones
2016-05-10 11:45     ` Paolo Bonzini
2016-05-10 12:41       ` Radim Krčmář
2016-05-10 14:32         ` Paolo Bonzini
2016-05-10 15:31           ` Radim Krčmář [this message]
2016-05-10 15:46             ` Paolo Bonzini
2016-05-10 16:17               ` Radim Krčmář
2016-04-15 20:52 ` [PATCH v3 9/9] run_tests: log stderr Radim Krčmář
2016-04-19  7:26   ` Andrew Jones
2016-04-19 12:13     ` Radim Krčmář
2016-05-10 11:41   ` Paolo Bonzini
2016-05-10 12:47     ` Radim Krčmář
2016-04-19  7:31 ` [PATCH kvm-unit-tests v3 0/9] Improve the output of test runners Andrew Jones
2016-04-19 12:14   ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160510153134.GE12472@potion \
    --to=rkrcmar@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox