From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PART1 V5 07/13] KVM: x86: Detect and Initialize AVIC support Date: Tue, 10 May 2016 18:24:21 +0200 Message-ID: <20160510162421.GE16752@pd.tnic> References: <1462388992-25242-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1462388992-25242-8-git-send-email-Suravee.Suthikulpanit@amd.com> <20160510091447.GA16752@pd.tnic> <5731F379.9080309@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Suravee Suthikulpanit , rkrcmar@redhat.com, joro@8bytes.org, gleb@kernel.org, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com, sherry.hurwitz@amd.com To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <5731F379.9080309@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, May 10, 2016 at 04:43:05PM +0200, Paolo Bonzini wrote: > That was actually our suggestion. Despite the long names, the lines do > not come out too long because the masks are only used for writing > fields, not very much for reading them (e.g. in complex "if" conditions). Sure but how can one even read that? AVIC_PHYSICAL_ID_ENTRY_HOST_PHYSICAL_ID_MASK AVIC's physical ID entry's host's physical ID's mask? That sucks in any language :-) -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.