From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] KVM: x86: make hwapic_isr_update and hwapic_irr_update look the same Date: Wed, 11 May 2016 14:46:39 +0200 Message-ID: <20160511124638.GA1859@potion> References: <1462898903-45526-1-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46761 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbcEKMqm (ORCPT ); Wed, 11 May 2016 08:46:42 -0400 Content-Disposition: inline In-Reply-To: <1462898903-45526-1-git-send-email-pbonzini@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2016-05-10 18:48+0200, Paolo Bonzini: > Neither APICv nor AVIC actually need the first argument of > hwapic_isr_update, but the vCPU makes more sense than passing the > pointer to the whole virtual machine! In fact in the APICv case it's > just because the vCPU is used implicitly, through the loaded VMCS. >=20 > The second argument instead is named differently, make it consistent. >=20 > Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99