From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [kvm-unit-tests PATCH 2/2] lib/util,arm,powerpc: replace parse_keyval with better helpers Date: Thu, 12 May 2016 15:22:09 +0200 Message-ID: <20160512132209.GC5864@potion> References: <1463000114-3572-1-git-send-email-rkrcmar@redhat.com> <1463000114-3572-3-git-send-email-rkrcmar@redhat.com> <20160512071908.537ltvwkiiekqvri@hawk.localdomain> <20160512080551.3sm5cj6bc26fkkty@hawk.localdomain> <056cf3b0-99f1-a792-def6-cb4c82e72881@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Jones , kvm@vger.kernel.org, Paolo Bonzini , Thomas Huth To: Laurent Vivier Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50881 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbcELNWO (ORCPT ); Thu, 12 May 2016 09:22:14 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24DC663323 for ; Thu, 12 May 2016 13:22:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: <056cf3b0-99f1-a792-def6-cb4c82e72881@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2016-05-12 10:09+0200, Laurent Vivier: > I don't know if it can help, but instead of creating our own API, > perhaps we can implement getopt() and getopt_long() and use them? A known API is a good idea as long I'm not the one implementing it. :) > Or is it over-engineered? Yeah, getopt would make both callers and the library more complicated.