Re: [kvm-unit-tests PATCH v2 1/2] arm/arm64: Makefile cleanup

[Wei Yang <richard.weiyang@gmail.com>]

On Tue, May 17, 2016 at 02:35:21PM +0200, Paolo Bonzini wrote:
>
>
>On 14/05/2016 15:30, Wei Yang wrote:
>> On Tue, May 10, 2016 at 06:55:43PM +0200, Andrew Jones wrote:
>>> This does the same cleanup as 'x86: Makefile refine'. .PRECIOUS
>>> is used (as opposed to .SECONDARY), because .SECONDARY doesn't
>>> accept target patterns.
>>>
>>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>> 
>> Is it possible to add 
>> 
>> Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
>
>Too late, sorry; the commit has been pushed already.
>

OK, that's fine.

BTW, do I need to reply with Reviewed-by in each patch version? I thought just
reply to one of it and the following versions would contain it. Or I missed
the rule?

>Paolo
>
>> Now?
>> 
>>> ---
>>> arm/Makefile.common | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/arm/Makefile.common b/arm/Makefile.common
>>> index 9a2d61fc88a27..a786fcf94154f 100644
>>> --- a/arm/Makefile.common
>>> +++ b/arm/Makefile.common
>>> @@ -24,6 +24,9 @@ CFLAGS += -Wextra
>>> CFLAGS += -O2
>>> CFLAGS += -I lib -I lib/libfdt
>>>
>>> +# We want to keep intermediate files
>>> +.PRECIOUS: %.elf %.o
>>> +
>>> asm-offsets = lib/$(ARCH)/asm-offsets.h
>>> include scripts/asm-offsets.mak
>>>
>>> @@ -48,7 +51,7 @@ start_addr := $(shell printf "%x\n" $$(( $(phys_base) + $(kernel_offset) )))
>>>
>>> FLATLIBS = $(libcflat) $(LIBFDT_archive) $(libgcc) $(libeabi)
>>> %.elf: LDFLAGS = $(CFLAGS) -nostdlib
>>> -%.elf: %.o $(FLATLIBS) arm/flat.lds
>>> +%.elf: %.o $(FLATLIBS) arm/flat.lds $(cstart.o)
>>> 	$(CC) $(LDFLAGS) -o $@ \
>>> 		-Wl,-T,arm/flat.lds,--build-id=none,-Ttext=$(start_addr) \
>>> 		$(filter %.o, $^) $(FLATLIBS)
>>> @@ -69,7 +72,4 @@ generated_files = $(asm-offsets)
>>>
>>> test_cases: $(generated_files) $(tests-common) $(tests)
>>>
>>> -$(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
>>> -$(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
>>> -
>>> $(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets)
>>> -- 
>>> 2.4.11
>> 

-- 
Wei Yang
Help you, Help me