From: Roman Kagan <rkagan@virtuozzo.com>
To: Steve Rutherford <srutherford@google.com>
Cc: KVM list <kvm@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"Denis V. Lunev" <den@openvz.org>,
Yang Zhang <yang.zhang.wz@gmail.com>
Subject: Re: [PATCH v3] kvm:vmx: more complete state update on APICv on/off
Date: Thu, 19 May 2016 12:34:06 +0300 [thread overview]
Message-ID: <20160519093405.GI13638@rkaganb.sw.ru> (raw)
In-Reply-To: <CABayD+dEsvJHG3j10kuq0n5HmaXdzQpQkFgm6inYnBZjGCREHQ@mail.gmail.com>
On Wed, May 18, 2016 at 02:49:48PM -0700, Steve Rutherford wrote:
> This patch looks good.
>
> I don't believe you need to explicitly check virtualize x2apic mode,
> given that `vcpu->arch.apic_base & X2APIC_ENABLE &&
> kvm_vcpu_apicv_active(vcpu)` implies that virtualize x2apic mode is
> enabled (because KVM currently never re-enables apicv after disabling
> it with the SyncIC), but being explicit is probably easier to
> maintain.
This was exactly my intent.
Thanks,
Roman.
next prev parent reply other threads:[~2016-05-19 9:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 14:48 [PATCH v3] kvm:vmx: more complete state update on APICv on/off Roman Kagan
2016-05-18 21:49 ` Steve Rutherford
2016-05-19 9:34 ` Roman Kagan [this message]
2016-05-19 1:38 ` Yang Zhang
2016-05-19 9:29 ` Roman Kagan
2016-05-19 2:01 ` Yang Zhang
2016-05-19 5:40 ` Denis V. Lunev
2016-05-20 1:15 ` Yang Zhang
2016-05-20 6:32 ` Roman Kagan
2016-05-20 6:38 ` Denis V. Lunev
2016-05-23 1:34 ` Yang Zhang
2016-05-23 14:18 ` Paolo Bonzini
2016-05-24 1:23 ` Yang Zhang
2016-05-24 2:09 ` Wincy Van
2016-05-24 10:42 ` Paolo Bonzini
2016-05-24 12:03 ` Wincy Van
2016-05-23 14:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519093405.GI13638@rkaganb.sw.ru \
--to=rkagan@virtuozzo.com \
--cc=den@openvz.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=srutherford@google.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox