From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Subject: Re: [PATCH 6/9] KVM: x86: directly call recalculate_apic_map on lapic restore Date: Mon, 23 May 2016 16:30:48 +0800 Message-ID: <20160523083048.GD8247@pxdev.xzpeter.org> References: <1462568045-31085-1-git-send-email-rkrcmar@redhat.com> <1462568045-31085-7-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini , "Lan, Tianyu" , Igor Mammedov , Jan Kiszka To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47780 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932088AbcEWIaz (ORCPT ); Mon, 23 May 2016 04:30:55 -0400 Content-Disposition: inline In-Reply-To: <1462568045-31085-7-git-send-email-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, May 06, 2016 at 10:54:02PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: > The get/set dance was just for that. >=20 > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 Reviewed-by: Peter Xu > --- > arch/x86/kvm/lapic.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > index 6ae5e74031d6..615067b41dde 100644 > --- a/arch/x86/kvm/lapic.c > +++ b/arch/x86/kvm/lapic.c > @@ -1933,8 +1933,8 @@ void kvm_apic_post_state_restore(struct kvm_vcp= u *vcpu, > /* set SPIV separately to get count of SW disabled APICs right */ > apic_set_spiv(apic, *((u32 *)(s->regs + APIC_SPIV))); > memcpy(vcpu->arch.apic->regs, s->regs, sizeof *s); > - /* call kvm_apic_set_id() to put apic into apic_map */ > - kvm_apic_set_id(apic, kvm_apic_id(apic)); > + /* put apic into apic_map */ > + recalculate_apic_map(vcpu->kvm); > kvm_apic_set_version(vcpu); > =20 > apic_update_ppr(apic); > --=20 > 2.8.2 >=20