From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [kvm-unit-tests PATCH v4 02/13] x86/*: report skipped tests Date: Wed, 25 May 2016 19:23:53 +0200 Message-ID: <20160525172352.GB8077@potion> References: <1462983171-4208-1-git-send-email-rkrcmar@redhat.com> <1462983171-4208-3-git-send-email-rkrcmar@redhat.com> <573B0C67.8010707@redhat.com> <20160525171927.GA8077@potion> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Andrew Jones To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43575 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754167AbcEYRX4 (ORCPT ); Wed, 25 May 2016 13:23:56 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF6FCD6D20 for ; Wed, 25 May 2016 17:23:55 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160525171927.GA8077@potion> Sender: kvm-owner@vger.kernel.org List-ID: 2016-05-25 19:19+0200, Radim Kr=C4=8Dm=C3=A1=C5=99: > is that summary will now print >=20 > SKIP pku (1 tests, 1 skipped) >=20 > instead of previous >=20 > SKIP pku (0 tests) >=20 > I like "0 tests" summary better and only x86/hyperv_synic does the > opposite, so a fix could go both ways. The fixup below does the other way. And the commit message could read "Some care to consistency [...]" with either of them. :) ---8<--- diff --git a/x86/hyperv_synic.c b/x86/hyperv_synic.c index f5eb82bb7336..5a06fb724a87 100644 --- a/x86/hyperv_synic.c +++ b/x86/hyperv_synic.c @@ -202,7 +202,7 @@ int main(int ac, char **av) =20 report("Hyper-V SynIC test", ok); } else { - report_skip("Hyper-V SynIC is not supported"); + printf("Hyper-V SynIC is not supported"); } =20 return report_summary(); diff --git a/x86/pku.c b/x86/pku.c index 6214f0bc151f..488cce3c6fdf 100644 --- a/x86/pku.c +++ b/x86/pku.c @@ -67,7 +67,7 @@ int main(int ac, char **av) unsigned int pkru_wd =3D 0x20; =20 if (!(cpuid_indexed(7, 0).c & (1 << X86_FEATURE_PKU))) { - printf("PKU not enabled, aborting\n"); + printf("PKU not enabled\n"); return report_summary(); } =20 diff --git a/x86/smap.c b/x86/smap.c index c9de081a474b..69dd80915c4a 100644 --- a/x86/smap.c +++ b/x86/smap.c @@ -92,7 +92,7 @@ int main(int ac, char **av) unsigned long i; =20 if (!(cpuid_indexed(7, 0).b & (1 << X86_FEATURE_SMAP))) { - printf("SMAP not enabled, aborting\n"); + printf("SMAP not enabled\n"); return report_summary(); } =20