public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Kai Huang <kai.huang@linux.intel.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm/x86: remove unnecessary header file inclusion
Date: Tue, 31 May 2016 15:49:46 +0200	[thread overview]
Message-ID: <20160531134945.GD30721@potion> (raw)
In-Reply-To: <1464672074-8864-1-git-send-email-kai.huang@linux.intel.com>

2016-05-31 13:21+0800, Kai Huang:
> arch/x86/kvm/iommu.c includes <linux/intel-iommu.h> and <linux/dmar.h>, which
> both are unnecessary, in fact incorrect to be here as they are intel specific.
> 
> Building kvm on x86 passed after removing above inclusion.
> 
> Signed-off-by: Kai Huang <kai.huang@linux.intel.com>
> ---

Applied, thanks.

>  arch/x86/kvm/iommu.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/iommu.c b/arch/x86/kvm/iommu.c
> index a22a488..15d8fff 100644
> --- a/arch/x86/kvm/iommu.c
> +++ b/arch/x86/kvm/iommu.c
> @@ -28,9 +28,7 @@
>  #include <linux/module.h>
>  #include <linux/pci.h>
>  #include <linux/stat.h>
> -#include <linux/dmar.h>
>  #include <linux/iommu.h>
> -#include <linux/intel-iommu.h>
>  #include "assigned-dev.h"
>  
>  static bool allow_unsafe_assigned_interrupts;
> -- 
> 2.7.4
> 

      reply	other threads:[~2016-05-31 13:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31  5:21 [PATCH] kvm/x86: remove unnecessary header file inclusion Kai Huang
2016-05-31 13:49 ` Radim Krčmář [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160531134945.GD30721@potion \
    --to=rkrcmar@redhat.com \
    --cc=kai.huang@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox