public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kvm/x86: remove unnecessary header file inclusion
@ 2016-05-31  5:21 Kai Huang
  2016-05-31 13:49 ` Radim Krčmář
  0 siblings, 1 reply; 2+ messages in thread
From: Kai Huang @ 2016-05-31  5:21 UTC (permalink / raw)
  To: pbonzini, rkrcmar, kvm; +Cc: Kai Huang

arch/x86/kvm/iommu.c includes <linux/intel-iommu.h> and <linux/dmar.h>, which
both are unnecessary, in fact incorrect to be here as they are intel specific.

Building kvm on x86 passed after removing above inclusion.

Signed-off-by: Kai Huang <kai.huang@linux.intel.com>
---
 arch/x86/kvm/iommu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/kvm/iommu.c b/arch/x86/kvm/iommu.c
index a22a488..15d8fff 100644
--- a/arch/x86/kvm/iommu.c
+++ b/arch/x86/kvm/iommu.c
@@ -28,9 +28,7 @@
 #include <linux/module.h>
 #include <linux/pci.h>
 #include <linux/stat.h>
-#include <linux/dmar.h>
 #include <linux/iommu.h>
-#include <linux/intel-iommu.h>
 #include "assigned-dev.h"
 
 static bool allow_unsafe_assigned_interrupts;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kvm/x86: remove unnecessary header file inclusion
  2016-05-31  5:21 [PATCH] kvm/x86: remove unnecessary header file inclusion Kai Huang
@ 2016-05-31 13:49 ` Radim Krčmář
  0 siblings, 0 replies; 2+ messages in thread
From: Radim Krčmář @ 2016-05-31 13:49 UTC (permalink / raw)
  To: Kai Huang; +Cc: pbonzini, kvm

2016-05-31 13:21+0800, Kai Huang:
> arch/x86/kvm/iommu.c includes <linux/intel-iommu.h> and <linux/dmar.h>, which
> both are unnecessary, in fact incorrect to be here as they are intel specific.
> 
> Building kvm on x86 passed after removing above inclusion.
> 
> Signed-off-by: Kai Huang <kai.huang@linux.intel.com>
> ---

Applied, thanks.

>  arch/x86/kvm/iommu.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/iommu.c b/arch/x86/kvm/iommu.c
> index a22a488..15d8fff 100644
> --- a/arch/x86/kvm/iommu.c
> +++ b/arch/x86/kvm/iommu.c
> @@ -28,9 +28,7 @@
>  #include <linux/module.h>
>  #include <linux/pci.h>
>  #include <linux/stat.h>
> -#include <linux/dmar.h>
>  #include <linux/iommu.h>
> -#include <linux/intel-iommu.h>
>  #include "assigned-dev.h"
>  
>  static bool allow_unsafe_assigned_interrupts;
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-31 13:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-31  5:21 [PATCH] kvm/x86: remove unnecessary header file inclusion Kai Huang
2016-05-31 13:49 ` Radim Krčmář

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox