public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: "Lukáš Doktor" <ldoktor@redhat.com>
Cc: kvm@vger.kernel.org, drjones@redhat.com, pbonzini@redhat.com,
	lvivier@redhat.com
Subject: Re: [PATCH] scripts/runtime: Adjust the premature_failure check
Date: Tue, 31 May 2016 17:56:18 +0200	[thread overview]
Message-ID: <20160531155617.GA11111@potion> (raw)
In-Reply-To: <20160531153747.GB30930@potion>

2016-05-31 17:37+0200, Radim Krčmář:
> 2016-05-31 12:54+0200, Lukáš Doktor:
>> The premature_failure check fails on qemu-system-ppc64 as it uses
>> different message. This patch modifies the condition so it works
>> (hopefully) for all archs.
>> ---
>> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
>> -    echo "$last_line" | grep -qi "could not load kernel" &&
>> +    echo "$last_line" | grep "_NO_FILE_4Uhere_" | grep -qi "no such file" &&
> 
> PPC uses "Could not open '_NO_FILE_4Uhere_': No such file [...]".
> The problem is that "No such file [...]" might be localized, so what
> about
>   grep -qi "could not \(load kernel\|open\) '_NO_FILE_4Uhere_'"
> ?

My tested local repo has a different line there:
(no idea how the posted version came around ...)

  echo "$last_line" | grep -qi "_NO_FILE_4Uhere_" &&

so we might be fine with it too, but I like the context check.

  reply	other threads:[~2016-05-31 15:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 10:54 [kvm-unit-tests PATCH] Adjust the premature_failure check Lukáš Doktor
2016-05-31 10:54 ` [PATCH] scripts/runtime: " Lukáš Doktor
2016-05-31 15:37   ` Radim Krčmář
2016-05-31 15:56     ` Radim Krčmář [this message]
2016-05-31 16:20       ` Paolo Bonzini
2016-05-31 18:13       ` Lukáš Doktor
2016-05-31 19:00         ` Radim Krčmář
  -- strict thread matches above, loose matches on Subject: below --
2016-06-01  6:20 [kvm-unit-tests PATCH v2] " Lukáš Doktor
2016-06-01  6:20 ` [PATCH] scripts/runtime: " Lukáš Doktor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160531155617.GA11111@potion \
    --to=rkrcmar@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=ldoktor@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox